1824160 - Ensure font visibility is in the Features manifest for experimentation.

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

We want to get this set and uplift to beta for experimenting in release.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

I'm kind of using this bug as a catch-all for things we want to get set up for the experiment for font families. I've added it to the list of things in the 'Site Not Working' list which is super subtle and not likely to be noticed by anyone.

I see that the 'Site Not Working' link is only shown when there are blocked resources, and that comes from ContentBlockingEvent. I am wondering if we want to wire up a FontBlockingEvent similarly (tied in with ReportBlockedFontFamilyName). In theory we could do a lot here: log stuff to web console, populate the protections panel in a fancy intelligent way ("This site tried to access 79 of your fonts!"). Get Telemetry for how many fonts are blocked...

But this is a lot of stuff and I'm sure we don't have time to do it all in time for an experiment, and probably not even for our first milestone. But it looks like there's a lot of possibilities here that are only medium difficulty because we have plumbing already for when a font is blocked.

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1824160: Add 'Fonts' to the reasons a Site Might Not Be Working r?timhuang

Depends on D173564

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1824160: Add Font Visibility to the experiments manifest r?timhuang

Depends on D173565

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

[Tracking Requested - why for this release]: We would like to be able to run the font visibility experiment in Release 111

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97842569220b
Add 'Fonts' to the reasons a Site Might Not Be Working r=fluent-reviewers,Gijs
https://hg.mozilla.org/integration/autoland/rev/65dfdf431801
Add Font Visibility to the experiments manifest r=timhuang

Comment 6

[Dianna Smith [:diannaS]]

just a friendly reminder that tomorrow is the last beta!

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/97842569220b
https://hg.mozilla.org/mozilla-central/rev/65dfdf431801

Comment 8

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 9324932 [details]
Bug 1824160: Add 'Fonts' to the reasons a Site Might Not Be Working r?timhuang

Beta/Release Uplift Approval Request

• User impact if declined: We will be unable to run the font visibility experiment in release
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): If we wanted to be more conservative, we could ignore the tiny UX patch and just take the feature manifest one. I'm not that familiar with UX code but I verified it on Nightly and it works as I expected it to.
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9324933 [details]
Bug 1824160: Add Font Visibility to the experiments manifest r?timhuang

Approved for 112.0b9

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9324932 [details]
Bug 1824160: Add 'Fonts' to the reasons a Site Might Not Be Working r?timhuang

Not sure how this works within the experiment but I would need flod approval for these changes to (en-US) and it is too late in the cycle to uplift this. If I misunderstood, please feel free to NI me before the build of b9 in a few hours.

Comment 11

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

No, that's okay, we can just take the manifest changes. Sorry I forgot about l10n, I don't typically do frontend work.

Comment 12

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f8ff33d57d94