Closed
Bug 1824216
Opened 2 years ago
Closed 2 years ago
Sync settings item in FxA panel should only be hidden (or disabled?) if syncing is off and 1 or fewer devices are connected.
Categories
(Firefox :: Sync, defect, P2)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
115 Branch
| Tracking | Status | |
|---|---|---|
| firefox115 | --- | fixed |
People
(Reporter: mconley, Assigned: skhamis)
References
Details
(Whiteboard: [fxsync-])
Attachments
(1 file)
This || should probably be an &&: https://searchfox.org/mozilla-central/rev/d630a6aad368dbbae4d90853f8cff5cb7c852407/browser/base/content/browser-sync.js#123
The original intent from the Proton spec (sorry, not public), was to hide this menuitem iff syncing is off and only 1 device is connected.
ddurst brings up a good point that we might consider disabling the item rather than hiding it.
|
||
Comment 1•2 years ago
|
||
The severity field is not set for this bug.
:teshaq, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(teshaq)
|
||
Updated•2 years ago
|
Severity: -- → S3
Flags: needinfo?(teshaq)
Priority: -- → P3
|
||
Comment 2•2 years ago
|
||
Bumping priority as this is a simple fix to a UX papercut.
Priority: P3 → P2
|
Assignee | |
Comment 3•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → skhamis
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•2 years ago
|
Whiteboard: [fxsync-]
|
||
Updated•2 years ago
|
Pushed by skhamis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2aa3ad747bc
Always show sync settings if sync is enabled r=markh,sync-reviewers
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox115:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•