182425 - Mach-O Build: Case sensitivity issues

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Syd Logan]

Building Mach o on OS X, no matter what I did, I kept dying in
intl/locale/src/nsLocaleService.cpp on line 56: script.h: No such file or directory.

#if defined( XP_MAC ) || defined( XP_MACOSX )
...
#include <script.h>
...
#endif

References to <[sS]cript.h> are found in a few source files in the tree, almost
always in macos-only files, which I would guess are only built in CFM builds or
on OS 9, or wrapped by #ifdef XP_MAC (but never XP_MACOSX, except in this case
in more generic platform independent sources). In most cases, the directive
spells the file with initial caps, i.e. <Script.h>. I failed to build
intl/ocale/src/mac/nsMacLocale.cpp as well.

I couldn't find script.h anywhere on my system. Script.h, however, is located in
a few, for example, somewhere below
/System/Library/Frameworks/CoreServices.framework.

I followed instructions for setting up Mach o builds, precisely.

My tree is on a native OS X Unix formatted drive. I suspected the problem is
that I'm running into an issue with case-sensitivity. To test this, I re-typed
the lines to read #include <Script.h> and my problem cleared up.  If this is in
fact the problem, I suspect that we need to make sure that case is correctly
specified for include files from here on out so that people don't waste a day
chasing their tails like I did.

Patch to follow for the changes I had to make. Filing against build config in
case there is some magic ignore case flag that can be passed to gcc.

Comment 1

[Syd Logan]

Attachment: some h file changes needed for UFS builds

Comment 2

[Syd Logan]

Comment on attachment 107847 [details] [diff] [review]
some h file changes needed for UFS builds

was given an sr= by sfraser. applying it now.

Comment 3

[Mike Pinkerton (not reading bugmail)]

have fun with that ufs formatted drive ;) you'll be in a world of hurt for just
about everything. ;) really, stick to HFS+.

Comment 4

[Syd Logan]

Checked in files for first patch, leaving open in case there are more files to
deal with.

Comment 5

[Syd Logan]

With a tree on HFS+, still have the problem, probably because my dev tools are
installed on a UFS drive (which is how I set up my system). 

Comment 6

[Jon Granrose]

QA to jj

Comment 7

[Syd Logan]

Attachment: another one

Comment 8

[Syd Logan]

reassigning to me

Comment 9

[Syd Logan]

since the build now builds cleaning, closing this one.