Closed
Bug 1824265
Opened 3 years ago
Closed 3 years ago
Error messages for asyncMap failures are vague
Categories
(Core :: Graphics: WebGPU, enhancement)
Core
Graphics: WebGPU
Tracking
()
RESOLVED
FIXED
113 Branch
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file)
Some errors from GPUBuffer.mapAsync are pretty obscure. "Invalid buffer", with no context, is pretty impossible to debug.
|
Assignee | |
Comment 1•3 years ago
|
||
Calling GPUBuffer.mapAsync returns a Promise that is rejected if something goes wrong mapping the buffer, but Firefox's error message doesn't really say anything to indicate that mapping was involved: "Invalid buffer" is a bit mysterious.
Ideally we would attach call stacks to these promises - and I think there is a way to do that - but for now this patch just changes the error messages to mention mapping.
While we're in the neighborhood, improve some NS_WARNING messages.
|
||
Updated•3 years ago
|
Assignee: nobody → jimb
Attachment #9324795 -
Attachment description: WIP: Bug 1824265: Clarify WebGPU mapAsync error messages. → Bug 1824265: Clarify WebGPU mapAsync error messages.
Status: NEW → ASSIGNED
Pushed by jblandy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/820e9c5e37b4
Clarify WebGPU mapAsync error messages. r=webgpu-reviewers,teoxoy
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•