1824411 - [wpt-sync] Sync PR 39187 - Check cookie accessibility in requestStorageAccess WPTs

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39187 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39187
Details from upstream follow.

Chris Fredrickson <[e-mail]> wrote:

Check cookie accessibility in requestStorageAccess WPTs

This CL extends the existing WPTs for document.requestStorageAccess
such that they actually verify the accessibility of cookies after
storage access is obtained. This is just a check that the API does
what it's supposed to do, in addition to returning the result that
it's supposed to.

This would have caught https://crbug.com/1409163,
https://crbug.com/1409162, and https://crbug.com/1408969.

Change-Id: Icf53e696a709398f7cf0079d0047a9e5cba20b5e

Reviewed-on: https://chromium-review.googlesource.com/4369340
WPT-Export-Revision: 328878e7ce770d5192c3c8d02acf8ea0138fde77

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 39187 applied with additional changes from upstream: 005a7caf2265205dd0c5fb4a2ef8d053f5c24817, 1b710fdad025467914012012dd96b5b72fcd27b4, 1c0172b4ba7082ad9acdd40441c15d924623c487

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=adc7cfc833256a9b5799181a528bbfd7148f6396

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 61 tests and 16 subtests

## Status Summary

### Firefox
`OK`     : 44[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 45[GitHub]
`PASS`   : 282[GitHub] 309[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 311[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt]
`FAIL`   : 78[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 115[GitHub]
`TIMEOUT`: 14[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug] 18[Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt] 20[GitHub]
`ERROR`  : 3[Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt] 4[GitHub] 7[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug]
`NOTRUN` : 108[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 121[GitHub]

### Chrome
`OK`     : 54
`PASS`   : 466
`FAIL`   : 34
`TIMEOUT`: 2
`ERROR`  : 6
`NOTRUN` : 5

### Safari
`OK`     : 50
`PASS`   : 334
`FAIL`   : 144
`TIMEOUT`: 10
`ERROR`  : 4
`NOTRUN` : 44

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=adc7cfc833256a9b5799181a528bbfd7148f6396)
[GitHub PR Head](https://wpt.fyi/results/?sha=ab212b122d8667fdb26eb575b9ab425afab914b2&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=ab212b122d8667fdb26eb575b9ab425afab914b2&label=pr_base)

## Details

### Firefox-only Failures
* [/cookies/samesite/form-get-blank-reload.https.html](https://wpt.live/cookies/samesite/form-get-blank-reload.https.html) [[wpt.fyi](https://wpt.fyi/results/cookies/samesite/form-get-blank-reload.https.html)]
  * Reloaded cross-site top-level form GETs are strictly same-site: `FAIL`
* [/cookies/samesite/window-open-reload.https.html](https://wpt.live/cookies/samesite/window-open-reload.https.html) [[wpt.fyi](https://wpt.fyi/results/cookies/samesite/window-open-reload.https.html)]
  * Reloaded cross-site auxiliary navigations are strictly same-site: `FAIL`
* [/service-workers/service-worker/credentials.https.html](https://wpt.live/service-workers/service-worker/credentials.https.html) [[wpt.fyi](https://wpt.fyi/results/service-workers/service-worker/credentials.https.html)]
  * Module with an imported statement should not have credentials: `FAIL`
* [/service-workers/service-worker/navigation-sets-cookie.https.html](https://wpt.live/service-workers/service-worker/navigation-sets-cookie.https.html) [[wpt.fyi](https://wpt.fyi/results/service-workers/service-worker/navigation-sets-cookie.https.html)]: `TIMEOUT`
  * Same-site top-level navigation with passthrough service worker should be able to set SameSite=* cookies.: `TIMEOUT`
  * Cross-site top-level navigation with passthrough service worker should be able to set SameSite=* cookies.: `NOTRUN`
  * Same-site top-level POST with passthrough service worker should be able to set SameSite=* cookies.: `NOTRUN`
  * Cross-site top-level with passthrough service worker POST should be able to set SameSite=* cookies.: `NOTRUN`
  * Same-site top-level navigation with navpreload service worker should be able to set SameSite=* cookies.: `NOTRUN`
  * Cross-site top-level navigation with navpreload service worker should be able to set SameSite=* cookies.: `NOTRUN`
  * Same-site top-level navigation with change-request service worker should be able to set SameSite=* cookies.: `NOTRUN`
  * Cross-site top-level navigation with change-request service worker should be able to set SameSite=* cookies.: `NOTRUN`
  * Same-site top-level POST with change-request service worker should be able to set SameSite=* cookies.: `NOTRUN`
  * Cross-site top-level with change-request service worker POST should be able to set SameSite=* cookies.: `NOTRUN`
  * Cleanup service workers: `NOTRUN`
* [/service-workers/service-worker/same-site-cookies.https.html](https://wpt.live/service-workers/service-worker/same-site-cookies.https.html) [[wpt.fyi](https://wpt.fyi/results/service-workers/service-worker/same-site-cookies.https.html)]: `TIMEOUT`
  * same-origin, window.open with passthrough: `TIMEOUT`
  * same-origin, window.open with change-request: `NOTRUN`
  * same-origin, window.open with navpreload: `NOTRUN`
  * same-site, window.open with no service worker: `NOTRUN`
  * same-site, window.open with fallback: `NOTRUN`
  * same-site, window.open with passthrough: `NOTRUN`
  * same-site, window.open with change-request: `NOTRUN`
  * same-site, window.open with navpreload: `NOTRUN`
  * cross-site, window.open with no service worker: `NOTRUN`
  * cross-site, window.open with fallback: `NOTRUN`
  * cross-site, window.open with passthrough: `NOTRUN`
  * cross-site, window.open with navpreload: `NOTRUN`
  * same-origin, window.open with no service worker and same-site redirect: `NOTRUN`
  * same-origin, window.open with fallback and same-site redirect: `NOTRUN`
  * same-origin, window.open with passthrough and same-site redirect: `NOTRUN`
  * same-origin, window.open with change-request and same-site redirect: `NOTRUN`
  * same-origin, window.open with navpreload and same-site redirect: `NOTRUN`
  * same-origin, window.open with no service worker and cross-site redirect: `NOTRUN`
  * same-origin, window.open with fallback and cross-site redirect: `NOTRUN`
  * same-origin, window.open with passthrough and cross-site redirect: `NOTRUN`
  * same-origin, window.open with navpreload and cross-site redirect: `NOTRUN`
  * same-origin, window.open with no service worker, cross-site redirect, and same-origin redirect: `NOTRUN`
  * same-origin, window.open with fallback, cross-site redirect, and same-origin redirect: `NOTRUN`
  * same-origin, window.open with passthrough, cross-site redirect, and same-origin redirect: `NOTRUN`
  * same-origin, window.open with navpreload, cross-site redirect, and same-origin redirect: `NOTRUN`
  * same-origin, nested window.open with cross-site middle frame and no service worker: `NOTRUN`
  * same-origin, nested window.open with cross-site middle frame and fallback service worker: `NOTRUN`
  * same-origin, nested window.open with cross-site middle frame and passthrough service worker: `NOTRUN`
  * same-origin, nested window.open with cross-site middle frame and change-request service worker: `NOTRUN`
  * same-origin, nested window.open with cross-site middle frame and navpreload service worker: `NOTRUN`
  * same-origin, form post with no service worker: `NOTRUN`
  * same-origin, form post with fallback: `NOTRUN`
  * same-origin, form post with passthrough: `NOTRUN`
  * same-origin, form post with change-request: `NOTRUN`
  * same-site, form post with no service worker: `NOTRUN`
  * same-site, form post with fallback: `NOTRUN`
  * same-site, form post with passthrough: `NOTRUN`
  * same-site, form post with change-request: `NOTRUN`
  * same-origin, form post with no service worker and same-site redirect: `NOTRUN`
  * same-origin, form post with fallback and same-site redirect: `NOTRUN`
  * same-origin, form post with passthrough and same-site redirect: `NOTRUN`
  * same-origin, form post with change-request and same-site redirect: `NOTRUN`
  * Cleanup service workers: `NOTRUN`
* [/storage-access-api/hasStorageAccess-insecure.sub.window.html](https://wpt.live/storage-access-api/hasStorageAccess-insecure.sub.window.html) [[wpt.fyi](https://wpt.fyi/results/storage-access-api/hasStorageAccess-insecure.sub.window.html)]
  * [cross-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: `FAIL`
  * [nested-cross-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: `FAIL`
* [/storage-access-api/hasStorageAccess.sub.https.window.html](https://wpt.live/storage-access-api/hasStorageAccess.sub.https.window.html) [[wpt.fyi](https://wpt.fyi/results/storage-access-api/hasStorageAccess.sub.https.window.html)]
  * [cross-site-frame] document.hasStorageAccess() should not be allowed by default unless in top-level frame or same-origin iframe.: `FAIL`
  * [nested-cross-site-frame] document.hasStorageAccess() should not be allowed by default unless in top-level frame or same-origin iframe.: `FAIL`
* [/storage-access-api/requestStorageAccess-insecure.sub.window.html](https://wpt.live/storage-access-api/requestStorageAccess-insecure.sub.window.html) [[wpt.fyi](https://wpt.fyi/results/storage-access-api/requestStorageAccess-insecure.sub.window.html)]: `TIMEOUT`
* [/storage-access-api/requestStorageAccess-non-fully-active.sub.https.window.html](https://wpt.live/storage-access-api/requestStorageAccess-non-fully-active.sub.https.window.html) [[wpt.fyi](https://wpt.fyi/results/storage-access-api/requestStorageAccess-non-fully-active.sub.https.window.html)]: `TIMEOUT`

(See attachment for full changes)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7069c9a48de
[wpt PR 39187] - Check cookie accessibility in requestStorageAccess WPTs, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d03ea87cd87b
[wpt PR 39187] - Update wpt metadata, a=testonly

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f7069c9a48de
https://hg.mozilla.org/mozilla-central/rev/d03ea87cd87b