Closed Bug 1824434 Opened 3 years ago Closed 3 years ago

Improve visibility of licensing info in Focus menus

Categories

(Focus :: General, enhancement, P1)

Product:
Focus
Component:
General
Platform:
All
Android
Type:
enhancement

Tracking

(firefox111 wontfix, firefox112 verified, firefox113 verified)

Status:
VERIFIED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox111 --- wontfix
firefox112 --- verified
firefox113 --- verified

People

(Reporter: jonalmeida, Assigned: jonalmeida)

References

Details

(Whiteboard: [geckoview:m113])

Attachments

(2 files)

[mozilla-mobile/firefox-android] Bug 1824434 - Improve visibility of license info (#1501)
59 bytes, text/x-github-pull-request
Details | Review
[mozilla-mobile/firefox-android] Bug 1824434 - Improve visibility of license info (backport #1501) (#1526)
59 bytes, text/x-github-pull-request
diannaS
: approval-mozilla-release+
Details | Review

Access to the license information can be better improved within our menus.

Severity: -- → N/A
status-firefox111: --- → affected
status-firefox112: --- → affected
status-firefox113: --- → affected
Priority: -- → P1
See Also: → 1825873
Target Milestone: --- → 113 Branch
Status: NEW → ASSIGNED
Authored by https://github.com/jonalmeida https://github.com/mozilla-mobile/firefox-android/commit/0fe63c0f1d44b81b32dc77f61e5a809c27acfc95 [main] Bug 1824434 - Improve visibility of license info (#1501)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox113: affected → fixed
status-firefox113: affected → fixed
Flags: qe-verify+
Resolution: --- → FIXED

Comment on attachment 9326361 [details] [review]
[mozilla-mobile/firefox-android] Bug 1824434 - Improve visibility of license info (#1501)

Beta/Release Uplift Approval Request

  • User impact if declined: Visibility of our license information is not as discoverable as we would like it to be.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Open Focus.
  1. Go to Settings -> Mozilla.
  2. Verify you can see 'Libraries that we use' and 'Licensing information'.
  3. Verify clicking 'Libraries that we use' shows a list of libraries and their licenses.
  4. Verify clicking 'Licensing information' opens to about:license.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The licensing information already existed in our apps before. This patch increases the visibility of it.

There are new UI tests to cover that this change does not regress.

  • String changes made/needed: Yes. Okay to uplift without translations for now.
  • Is Android affected?: Yes
Attachment #9326361 - Flags: approval-mozilla-beta?

Has the fix been verified in Nightly?: No

Once verified on Nightly, the uplift will be done.

(qe-verify+ is already set)

Comment on attachment 9326682 [details] [review] [mozilla-mobile/firefox-android] Bug 1824434 - Improve visibility of license info (backport #1501) (#1526) Approved for Mobile 112.0 rc1
Attachment #9326682 - Flags: approval-mozilla-release+
Comment on attachment 9326361 [details] [review] [mozilla-mobile/firefox-android] Bug 1824434 - Improve visibility of license info (#1501) Removing flag since it was added to the backport patch
Attachment #9326361 - Flags: approval-mozilla-beta?

Verified as implemented on the latest Focus Nightly 113.0a1 from 4/4, and on the latest RC 112.0 with Google Pixel 6 (Android 13).

Status: RESOLVED → VERIFIED
status-firefox112: fixed → verified
status-firefox113: fixed → verified
Flags: qe-verify+

Thank you Mira and Dianna!

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: