1824473 - Convert toolkit/components/formautofill to ES modules

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P3)

Description

[Stephanie Cunnane [:scunnane]]

As part of the ESMification project, we should migrate the code in toolkit/components/formautofill to use ES modules.

Comment 1

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 1824473 - Convert toolkit/components/formautofill to ES modules. r?Standard8

Depends on D171884

Comment 2

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 1824473 - Update consumers of toolkit/components/formautofill to import ES modules directly. r?Standard8

Depends on D173586

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4203fbb8f229
Convert toolkit/components/formautofill to ES modules. r=Standard8,credential-management-reviewers,sgalich
https://hg.mozilla.org/integration/autoland/rev/01046e78078c
Update consumers of toolkit/components/formautofill to import ES modules directly. r=Standard8,geckoview-reviewers,credential-management-reviewers,sgalich,m_kato

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in browser/extensions/formautofill/test/<...>.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/ce3ec981960f4b3d0a66a645caf0d6a3c4c22930

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/address/browser_address_doorhanger_display.js | head.js import threw an exception

Failure log -> TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/mochitest/test_address_level_1_submission.html | uncaught exception - Error: Failed to load resource

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | file only referenced from unreferenced files:

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fbc5b6422c7
Convert toolkit/components/formautofill to ES modules. r=Standard8,credential-management-reviewers,sgalich
https://hg.mozilla.org/integration/autoland/rev/8dd52b2dae6b
Update consumers of toolkit/components/formautofill to import ES modules directly. r=Standard8,geckoview-reviewers,credential-management-reviewers,sgalich,m_kato

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on test_address_level_1_submission.html

• backout: https://hg.mozilla.org/integration/autoland/rev/608425bed69d4f6a0d54e8cff545476d22f1233e
• push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=SQ0UF0aBR4-f8-7VGsMMcA.0&revision=8dd52b2dae6b5d0a8958de3fa41420e13d89bdec&group_state=expanded
• failure log: https://treeherder.mozilla.org/logviewer?job_id=410840969&repo=autoland&lineNumber=3691

[task 2023-03-30T18:10:18.281Z] 18:10:18     INFO - TEST-START | browser/extensions/formautofill/test/mochitest/test_address_level_1_submission.html
[task 2023-03-30T18:10:18.755Z] 18:10:18     INFO - GECKO(2426) | [Parent 2426, IPDL Background] WARNING: IPC Connection Error: [Parent][PBackgroundParent] RunMessage(msgname=PRemoteWorkerService::Msg___delete__) Channel closing: too late to send/recv, messages will be lost: file /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1927
[task 2023-03-30T18:10:18.804Z] 18:10:18     INFO - GECKO(2426) | [Child 2526, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3396
[task 2023-03-30T18:10:18.810Z] 18:10:18     INFO - GECKO(2426) | [Child 2526, Main Thread] WARNING: NS_ENSURE_TRUE(InitStaticMembers()) failed: file /builds/worker/workspace/obj-build/dist/include/mozilla/Preferences.h:129
[task 2023-03-30T18:10:18.817Z] 18:10:18     INFO - GECKO(2426) | [Child 2526, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4689
[task 2023-03-30T18:10:21.552Z] 18:10:21     INFO - TEST-INFO | started process screentopng
[task 2023-03-30T18:10:21.781Z] 18:10:21     INFO - TEST-INFO | screentopng: exit 0
[task 2023-03-30T18:10:21.783Z] 18:10:21     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/mochitest/test_address_level_1_submission.html | uncaught exception - ReferenceError: ChromeUtils is not defined at @https://mochi.test:8888/tests/browser/extensions/formautofill/test/mochitest/formautofill_common.js:13:31
[task 2023-03-30T18:10:21.784Z] 18:10:21     INFO - 
[task 2023-03-30T18:10:21.784Z] 18:10:21     INFO - simpletestOnerror@https://mochi.test:8888/tests/SimpleTest/SimpleTest.js:1996:18
[task 2023-03-30T18:10:21.784Z] 18:10:21     INFO - OnErrorEventHandlerNonNull*@https://mochi.test:8888/tests/SimpleTest/SimpleTest.js:1971:1
[task 2023-03-30T18:10:21.785Z] 18:10:21     INFO - GECKO(2426) | JavaScript error: https://mochi.test:8888/tests/browser/extensions/formautofill/test/mochitest/formautofill_common.js, line 13: ReferenceError: ChromeUtils is not defined
[task 2023-03-30T18:10:21.792Z] 18:10:21     INFO - GECKO(2426) | [Parent 2426, Main Thread] WARNING: NS_ENSURE_TRUE(she && she->mInfo->mSharedState.Get()) failed: file /builds/worker/checkouts/gecko/docshell/shistory/SessionHistoryEntry.cpp:1155
[task 2023-03-30T18:10:21.807Z] 18:10:21     INFO - TEST-PASS | browser/extensions/formautofill/test/mochitest/test_address_level_1_submission.html | Got autocomplete popup - {"mInput":null,"mPopupOpen":false,"_currentIndex":0,"_disabledItemClicked":false} == true 

• Also failing: TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/mochitest/creditCard/test_basic_creditcard_autocomplete_form.html | uncaught exception - ReferenceError: ChromeUtils is not defined at @https://example.com/tests/browser/extensions/formautofill/test/mochitest/formautofill_common.js:13:31

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b73ead08bb19
Convert toolkit/components/formautofill to ES modules. r=Standard8,credential-management-reviewers,sgalich
https://hg.mozilla.org/integration/autoland/rev/b38aeb74da71
Update consumers of toolkit/components/formautofill to import ES modules directly. r=Standard8,geckoview-reviewers,credential-management-reviewers,sgalich,m_kato

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1824473) for causing failures in test_clear_form.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b38aeb74da713bf7a4e34a4c7ba7b509281a855e&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-plain-swr%2C11&selectedTaskRun=JJ6zfqLZR5WBsrMRtPLARw.0

Log: https://treeherder.mozilla.org/logviewer?job_id=410991378&repo=autoland&lineNumber=2851
https://treeherder.mozilla.org/logviewer?job_id=410991762&repo=autoland&lineNumber=2763
https://treeherder.mozilla.org/logviewer?job_id=410991680&repo=autoland&lineNumber=2803

Backout: https://hg.mozilla.org/integration/autoland/rev/e2239a65ed6cf04cc334733eeb775ab3c44fcca7

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfea5761eec1
Convert toolkit/components/formautofill to ES modules. r=Standard8,credential-management-reviewers,sgalich
https://hg.mozilla.org/integration/autoland/rev/e28e812ef06d
Update consumers of toolkit/components/formautofill to import ES modules directly. r=Standard8,geckoview-reviewers,credential-management-reviewers,sgalich,m_kato

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cfea5761eec1
https://hg.mozilla.org/mozilla-central/rev/e28e812ef06d