1824543 - Add shopping_tab_displayed and is_shopping_page to the Impression Event

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[James Teow [:jteow]]

Have to add the following the Impression Event:

• shopping_tab_displayed: boolean - Whether the shopping tab was displayed.
• is_shopping_page: Based on the page url, whether the current page is a shopping page.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1824543 - Add shopping_tab_displayed and is_shopping_page to Impression Event - r?standard8,scunnane

Since we rely on the child process to parse this information, we need to
wait until the child has reported the presence of the shopping page
before sending the Impression event.

Depends on D175546

Comment 2

[James Teow [:jteow]]

Attachment: data-review-request-bug-1824543.md

Hi :jhirsch, the difference between this data review request and the original one for the impression event is we're adding two additional properties:

• Whether the SERP contains a shopping tab
• Whether the page is actually a SERP shopping page

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9328944 [details]
data-review-request-bug-1824543.md

data-review+

To clarify, the additions here are only two of the event properties described in the data-review request: shopping_tab_displayed and is_shopping_page.

---

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, the usual Firefox desktop data documentation.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the usual Firefox data collection opt-out in about:preferences.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, the team will monitor via the email aliases [e-mail], [e-mail].

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, interaction data.

5. Is the data collection request for default-on or default-off?

Default on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does the data collection use a third-party collection tool?

No.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a429e0af77b
Add shopping_tab_displayed and is_shopping_page to Impression Event - r=Standard8

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7a429e0af77b