1824761 - Troubleshoot.sys.mjs makes handling async errors difficult

Status: NEW

(Toolkit :: General, enhancement, P3)

Description

[Jim Blandy :jimb]

Troubleshoot.sys.mjs tries to accommodate asynchronous data providers, but the data collection loop in Troubleshoot.snapshot only handles errors thrown synchronously - if an async provider encounters errors in its callbacks, it has to handle those itself. Bug 1824638 shows that people do mess this up.

Comment 1

[:Gijs (he/him)]

I think Troubleshoot.sys.mjs was written before promises. If we wrote it today the snapshot functions would all just be async functions, and then the framework could handle the promise rejections more holistically. This should be a relatively straightforward transformation.