1824870 - Intermittent [TV] browser/components/migration/tests/browser/browser_safari_permissions.js | Uncaught exception in test bound test_safari_permissions - at resource://testing-common/sinon-7.2.7.js:3605 - TypeError: Attempted to wrap getMigrator which is al

Status: RESOLVED FIXED

(Firefox :: Migration, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=410407416&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/LX67BXZeTjKiY4L8C8WAog/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/LX67BXZeTjKiY4L8C8WAog/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

INFO - TEST-START | browser/components/migration/tests/browser/browser_safari_permissions.js
[task 2023-03-27T22:41:38.823Z] 22:41:38     INFO - TEST-INFO | started process screencapture
[task 2023-03-27T22:41:38.944Z] 22:41:38     INFO - TEST-INFO | screencapture: exit 0
[task 2023-03-27T22:41:38.944Z] 22:41:38     INFO - Buffered messages logged at 22:41:38
[task 2023-03-27T22:41:38.945Z] 22:41:38     INFO - Entering test bound test_safari_permissions
[task 2023-03-27T22:41:38.945Z] 22:41:38     INFO - Buffered messages finished
[task 2023-03-27T22:41:38.947Z] 22:41:38     INFO - TEST-UNEXPECTED-FAIL | browser/components/migration/tests/browser/browser_safari_permissions.js | Uncaught exception in test bound test_safari_permissions - at resource://testing-common/sinon-7.2.7.js:3605 - TypeError: Attempted to wrap getMigrator which is already wrapped
[task 2023-03-27T22:41:38.947Z] 22:41:38     INFO - Stack trace:
[task 2023-03-27T22:41:38.947Z] 22:41:38     INFO - checkWrappedMethod@resource://testing-common/sinon-7.2.7.js:3605:21
[task 2023-03-27T22:41:38.947Z] 22:41:38     INFO - wrapMethod@resource://testing-common/sinon-7.2.7.js:3653:31
[task 2023-03-27T22:41:38.947Z] 22:41:38     INFO - stub@resource://testing-common/sinon-7.2.7.js:3002:44
[task 2023-03-27T22:41:38.947Z] 22:41:38     INFO - stub@resource://testing-common/sinon-7.2.7.js:2099:33
[task 2023-03-27T22:41:38.947Z] 22:41:38     INFO - test_safari_permissions@chrome://mochitests/content/browser/browser/components/migration/tests/browser/browser_safari_permissions.js:33:9
[task 2023-03-27T22:41:38.947Z] 22:41:38     INFO - handleTask@chrome://mochikit/content/browser-test.js:1039:26
[task 2023-03-27T22:41:38.948Z] 22:41:38     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1111:18
[task 2023-03-27T22:41:38.948Z] 22:41:38     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1253:14
[task 2023-03-27T22:41:38.948Z] 22:41:38     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1022:14
[task 2023-03-27T22:41:38.948Z] 22:41:38     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1053:13
[task 2023-03-27T22:41:38.948Z] 22:41:38     INFO - 
[task 2023-03-27T22:41:38.948Z] 22:41:38     INFO - --------------
[task 2023-03-27T22:41:38.948Z] 22:41:38     INFO - wrapMethod@resource://testing-common/sinon-7.2.7.js:3679:26
[task 2023-03-27T22:41:38.948Z] 22:41:38     INFO - stub@resource://testing-common/sinon-7.2.7.js:3002:44
[task 2023-03-27T22:41:38.948Z] 22:41:38     INFO - stub@resource://testing-common/sinon-7.2.7.js:2099:33
[task 2023-03-27T22:41:38.948Z] 22:41:38     INFO - test_safari_permissions@chrome://mochitests/content/browser/browser/components/migration/tests/browser/browser_safari_permissions.js:33:9
[task 2023-03-27T22:41:38.948Z] 22:41:38     INFO - handleTask@chrome://mochikit/content/browser-test.js:1039:26
[task 2023-03-27T22:41:38.948Z] 22:41:38     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1111:18
[task 2023-03-27T22:41:38.949Z] 22:41:38     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1253:14
[task 2023-03-27T22:41:38.949Z] 22:41:38     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1022:14
[task 2023-03-27T22:41:38.949Z] 22:41:38     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1053:13
[task 2023-03-27T22:41:38.949Z] 22:41:38     INFO - Leaving test bound test_safari_permissions
[task 2023-03-27T22:41:39.167Z] 22:41:39     INFO - GECKO(1439) | MEMORY STAT | vsize 15742MB | residentFast 351MB | heapAllocated 186MB
[task 2023-03-27T22:41:39.167Z] 22:41:39     INFO - TEST-OK | browser/components/migration/tests/browser/browser_safari_permissions.js | took 347ms

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:mconley, since you are the author of the regressor, bug 1822676, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1822676

Comment 3

[Mike Conley (:mconley) (:⚙️)]

This is because I made the mistake of using sinon.stub here rather than sandbox.stub, so the restoration in the cleanup function doesn't revert the stub.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

This should be reproducible locally on macOS by using:

 ./mach mochitest browser/components/migration/tests/browser/browser_safari_permissions.js --repeat=2

Comment 5

[Intermittent Failures Robot]

4 failures in 3863 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 4

Platform and build breakdown:

• macosx1015-64-qr: 4
  • debug: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1824870&startday=2023-03-27&endday=2023-04-02&tree=all

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Hi portiawu, just so we're clear, presuming you can reproduce this issue reliably, the solution I propose is that you update this line to use sandbox.stub rather than sinon.stub. That way, when we restore the sandbox here at the end of the test, we'll remove the stub function.

Comment 7

[portiawuu]

Attachment: Bug 1824870 - Fix Sinon usage in browser_safari_permissions.js. r=mconley,kpatenio

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3344d8f2cd10
Fix Sinon usage in browser_safari_permissions.js. r=mconley,kpatenio

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/3344d8f2cd10