1824950 - coverity report: ScriptLoadContext.h Non-static class member "mColumnNo" is not initialized in this constructor nor in any functions that it calls

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

*** CID 1524505:  Uninitialized members  (UNINIT_CTOR)
/dom/script/ScriptLoadContext.cpp: 69 in mozilla::dom::ScriptLoadContext::ScriptLoadContext()()
63           mIsTracking(false),
64           mWasCompiledOMT(false),
65           mOffThreadToken(nullptr),
66           mRunnable(nullptr),
67           mLineNo(1),
68           mIsPreload(false),
>>>     CID 1524505:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mColumnNo" is not initialized in this constructor nor in any functions that it calls.
69           mUnreportedPreloadError(NS_OK) {}
70     
71     ScriptLoadContext::~ScriptLoadContext() {
72       MOZ_ASSERT(NS_IsMainThread());
73     
74       // Off-thread parsing must have completed by this point.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

We have a different initialization story for this member (we should still fix this)

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1824950 - Initialize ScriptLoadContext mColumnNo. r=mgaudet.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e286a70419ce
Initialize ScriptLoadContext mColumnNo. r=mgaudet.

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e286a70419ce