1824989 - Perma toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 439] Feature browser.startup.homepage.abouthome_cache.enabled when Gecko 113 merges to Beta on 2023-04-10

Status: VERIFIED FIXED

(Toolkit :: FeatureGate, defect)

Description

[Serban Stanca [:SerbanS]]

Central-as-beta-simulation

How to run these simulations

Failure log

[task 2023-03-28T12:31:04.431Z] 12:31:04     INFO -  TEST-START | toolkit/components/featuregates/test/unit/test_FeatureGate.js
[task 2023-03-28T12:31:07.396Z] 12:31:07  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGate.js | xpcshell return code: 0
[task 2023-03-28T12:31:07.396Z] 12:31:07     INFO -  TEST-INFO took 2963ms
[task 2023-03-28T12:31:07.396Z] 12:31:07     INFO -  >>>>>>>
[task 2023-03-28T12:31:07.397Z] 12:31:07     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-03-28T12:31:07.397Z] 12:31:07     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-03-28T12:31:07.397Z] 12:31:07     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-03-28T12:31:07.397Z] 12:31:07     INFO -  running event loop
[task 2023-03-28T12:31:07.397Z] 12:31:07     INFO -  toolkit/components/featuregates/test/unit/test_FeatureGate.js | Starting testReadAll
[task 2023-03-28T12:31:07.397Z] 12:31:07     INFO -  (xpcshell/head.js) | test testReadAll pending (2)
[task 2023-03-28T12:31:07.397Z] 12:31:07     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2023-03-28T12:31:07.397Z] 12:31:07     INFO -  TEST-PASS | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testReadAll - [testReadAll : 82] Features are returned in order of definition - "test-featureA" == "test-featureA"
<...>
[task 2023-03-28T12:31:07.453Z] 12:31:07     INFO -  TEST-PASS | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllHaveDefault - [testAllHaveDefault : 424] Feature webrtc-global-mute-toggles should have a non-null default value! - false != null
[task 2023-03-28T12:31:07.453Z] 12:31:07     INFO -  (xpcshell/head.js) | test run_next_test 7 pending (2)
[task 2023-03-28T12:31:07.454Z] 12:31:07     INFO -  (xpcshell/head.js) | test testAllHaveDefault finished (2)
[task 2023-03-28T12:31:07.454Z] 12:31:07     INFO -  toolkit/components/featuregates/test/unit/test_FeatureGate.js | Starting testAllDefaultsMatchSettings
[task 2023-03-28T12:31:07.455Z] 12:31:07     INFO -  (xpcshell/head.js) | test testAllDefaultsMatchSettings pending (2)
[task 2023-03-28T12:31:07.455Z] 12:31:07     INFO -  (xpcshell/head.js) | test run_next_test 7 finished (2)
[task 2023-03-28T12:31:07.456Z] 12:31:07  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 439] Feature browser.startup.homepage.abouthome_cache.enabled should match runtime value. - false == true
[task 2023-03-28T12:31:07.456Z] 12:31:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/components/featuregates/test/unit/test_FeatureGate.js:testAllDefaultsMatchSettings:439
[task 2023-03-28T12:31:07.457Z] 12:31:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:238
[task 2023-03-28T12:31:07.457Z] 12:31:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:585
[task 2023-03-28T12:31:07.457Z] 12:31:07     INFO -  -e:null:1
[task 2023-03-28T12:31:07.458Z] 12:31:07     INFO -  exiting test

Comment 1

[James Teh [:Jamie]]

This was actually regressed by bug 1824799. browser/app/profile/firefox.js was updated, but there also needs to be an update to toolkit/components/featuregates/Features.toml.

Comment 2

[Cosmin Sabou [:CosminS]]

This should be fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1824799#c5.
Will see in tomorrow's beta-sim.

Comment 3

[Cosmin Sabou [:CosminS]]

No longer happens in beta-sims.