1825116 - firefox-android: fix lint errors on mozilla-central

Status: RESOLVED FIXED

(Release Engineering :: General, task, P3)

Description

[Geoff Brown [:gbrown]]

When firefox-android code is linted on oak, we see a variety of lint failures:
https://treeherder.mozilla.org/logviewer?job_id=410470235&repo=oak
https://treeherder.mozilla.org/logviewer?job_id=410470218&repo=oak
https://treeherder.mozilla.org/logviewer?job_id=410470230&repo=oak
https://treeherder.mozilla.org/logviewer?job_id=410470195&repo=oak
https://treeherder.mozilla.org/logviewer?job_id=410470216&repo=oak
https://treeherder.mozilla.org/logviewer?job_id=410470196&repo=oak

If there are conflicts between lint rules on github vs mozilla-central, these changes might need to be finalized after firefox-android is migrated to mozilla-central, but I'm also seeing some clear wins that could be made now.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1825116 - Resolve many black, isort, and file-whitespace lint issues (#1568)

Comment 2

[BMO Github Automation]

Authored by https://github.com/gbrownmozilla
https://github.com/mozilla-mobile/firefox-android/commit/25869379daab6106706b58ecd3da1de83481df83
[main] Bug 1825116 - Resolve many black, isort, and file-whitespace lint issues

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1825116 - Resolve some codespell and rejected-words lint issues (#1628)

Comment 4

[BMO Github Automation]

Authored by https://github.com/gbrownmozilla
https://github.com/mozilla-mobile/firefox-android/commit/8d102332c9707c4f0ef33d5db4eac3a125c2acfc
[main] Bug 1825116 - Fix spelling errors found by codespell linter

Authored by https://github.com/gbrownmozilla
https://github.com/mozilla-mobile/firefox-android/commit/ecbb6766ef4038044c23adc46bf9740be6b02d9d
[main] Bug 1825116 - Resolve some warnings found by the rejected-words linter

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1825116 - Add license notice where missing (#1637)

Comment 6

[Geoff Brown [:gbrown]]

Notes from review of #1637:

• strings.xml (majority of license violations) will need to be handled via https://github.com/mozilla-l10n/android-l10n/issues/645 or excluded
• we will likely need to add a license linter exclusion for res/drawable/ ic_cc_*.xml -- credit card logos

Comment 7

[BMO Github Automation]

Authored by https://github.com/gbrownmozilla
https://github.com/mozilla-mobile/firefox-android/commit/487bc890e4fd221ea90209034c522d54ab237284
[main] Bug 1825116 - Add license notice where missing (#1637)

Comment 8

[Geoff Brown [:gbrown]]

I think that's about all I can do for now. Many lint failures remain, and more will inevitably be added while f-a is on github; we should revisit these issues closer to the actual migration.

One way forward would be to add exclusions (eg https://searchfox.org/mozilla-central/rev/31f5847a4494b3646edabbdd7ea39cb88509afe2/tools/lint/license.yml#6) for mobile/android/android-components|focus-android|fenix to all of the problematic linters, then work to resolve those after the migration.

Comment 9

[Geoff Brown [:gbrown]]

There are still a few failures seen on oak:

https://treeherder.mozilla.org/jobs?repo=oak&searchStr=lint&revision=c0dc034cd7934e03ddd0af95d6cf171804f5582d

I see a few more we can address on firefox-android...

Comment 10

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1825116 - Reformat some python files with black and avoid 'bare except' ruff warnings (#2803)

Comment 11

[BMO Github Automation]

Authored by https://github.com/gbrownmozilla
https://github.com/mozilla-mobile/firefox-android/commit/83e0bbb793c5f4b2297454bc3236f432c69fe3e6
[main] Bug 1825116 - Reformat some python files with black and avoid 'bare except' ruff warnings

Comment 12

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1825116 - fix a couple of typos (#3558)

Comment 13

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1825116 - add license info to animated_splash_screen.xml (#3559)

Comment 14

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1825116 - add missing MPL header to upstream_artifacts transform (#3561)

Comment 15

[BMO Github Automation]

Authored by https://github.com/jcristau
https://github.com/mozilla-mobile/firefox-android/commit/7945db4041b32e35cf6aa0ed8b38d1abae5bfe77
[main] Bug 1825116 - fix a couple of typos

Comment 16

[BMO Github Automation]

Authored by https://github.com/jcristau
https://github.com/mozilla-mobile/firefox-android/commit/2fc2fcf3afbf080919346524e01f3be713e96bdd
[main] Bug 1825116 - add missing MPL header to upstream_artifacts transform

Comment 17

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1825116 - delete trailing whitespace from docs (#3584)

Comment 18

[BMO Github Automation]

Authored by https://github.com/jcristau
https://github.com/mozilla-mobile/firefox-android/commit/0d33e82ac349ae7b807c7db3392272584fc73c9e
[main] Bug 1825116 - add license info to animated_splash_screen.xml

Comment 19

[BMO Github Automation]

Authored by https://github.com/jcristau
https://github.com/mozilla-mobile/firefox-android/commit/411697306b211268c347d9a173073ec3c42a1660
[main] Bug 1825116 - delete trailing whitespace from docs

Comment 20

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1825116 - Resolve many lint issues found on oak (#4551)

Comment 21

[BMO Github Automation]

Authored by https://github.com/gbrownmozilla
https://github.com/mozilla-mobile/firefox-android/commit/bd7fff165063c3a84dd893ad7790186e20da587e
[main] Bug 1825116 - Resolve many lint issues found on oak (#4551)

Comment 22

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1825116 - Consolidate attributes in build-apk kind.yml (#4579)

Comment 23

[BMO Github Automation]

Authored by https://github.com/gbrownmozilla
https://github.com/mozilla-mobile/firefox-android/commit/49c4291d440e631fe2c737a6b7b0bf1f7ac85232
[main] Bug 1825116 - Consolidate attributes in build-apk kind.yml (#4579)

Comment 24

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - Add lint exclusions for some troublesome firefox-android files. r=Standard8,bhearsum,geckoview-reviewers,releng-reviewers

Comment 25

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - Fixup notification configs in test_apk/ui_test_apk

Comment 26

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - fix python formatting issues in firefox-android scripts

Generated by
./mach lint -l black --fix taskcluster/android_taskgraph/ taskcluster/scripts/lint/ taskcluster/scripts/write-dummy-secret.py mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/experimentintegration/conftest.py mobile/android/fenix/automation/taskcluster/androidTest/parse-ui-test-fromfile.py mobile/android/focus-android/automation/taskcluster/androidTest/parse-ui-test*

Comment 27

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - android_taskgraph: ruff fixes

Generated with:
./mach lint -l ruff --fix taskcluster/android_taskgraph

Comment 28

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - ruff fix for fenix test

./mach lint -l ruff --fix mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/experimentintegration/conftest.py

Comment 29

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - fix yamllint errors

Comment 30

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - add rejected-words lint exception

Comment 31

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - add license lint exception

Comment 32

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - remove executable bit from yaml file

Comment 33

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - add exclusions for file-whitespace lint

Comment 34

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - add license lint exclusion for gradle-wrappers

Comment 35

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - misc reformatting with black

Comment 36

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - do not run spotless lint on firefox-android projects

Comment 37

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - update generated raptor perf docs

Comment 38

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - remove trailing whitespace from A-C changelog

Comment 39

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - fix yamllint error in android-startup-test

Comment 40

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - update file-whitespace lint excludes

Comment 41

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - update generated perf docs

Comment 42

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - add license header to testrail_conn script

Comment 43

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - ruff fixes

Comment 44

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - whitespace fixes

Comment 45

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - remove trailing whitespace from ConceptFetchDetector and test.

Comment 46

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - remove executable bit from png file.

Comment 47

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - fix ruff errors in test-lab script.

Comment 48

[Julien Cristau [:jcristau]]

Attachment: Bug 1825116 - remove trailing whitespace from android-components rfc.

Comment 49

[Geoff Brown [:gbrown]]

Attachment: Bug 1825116 - remaining whitespace fixes

Comment 50

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/mozilla-central/rev/f3c26d856e30
https://hg.mozilla.org/mozilla-central/rev/35db8d23936d
https://hg.mozilla.org/mozilla-central/rev/45ff58448262
https://hg.mozilla.org/mozilla-central/rev/7caa8bd12f58
https://hg.mozilla.org/mozilla-central/rev/62a9486d0bf8
https://hg.mozilla.org/mozilla-central/rev/272c61005d40
https://hg.mozilla.org/mozilla-central/rev/4698834ec417
https://hg.mozilla.org/mozilla-central/rev/8bba486b8bd2
https://hg.mozilla.org/mozilla-central/rev/4c3eda721945
https://hg.mozilla.org/mozilla-central/rev/43483328a51b
https://hg.mozilla.org/mozilla-central/rev/53957c99ad81
https://hg.mozilla.org/mozilla-central/rev/def61a31e127
https://hg.mozilla.org/mozilla-central/rev/6d8d66fc9d22
https://hg.mozilla.org/mozilla-central/rev/e7dc27104247
https://hg.mozilla.org/mozilla-central/rev/08ea6c338c2c