1825258 - Pressing `Esc` key on Unified Toolbar customize dialog should cancel

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, task)

Description

[Thomas D. (:thomas8)]

Getting out of UTB customization is pretty clumsy, that dialog is so all-over!
I keep looking for a close button in the upper right corner.
Lacking that, at least having an efficient default keyboard shortcut to get out of the dialog more easily would help much, also for QA testing. I'd hope that this is easy to implement with a global keydown listener on the dialog's main element.

Expected

• Pressing Esc key on Unified Toolbar customize dialog should cancel

Comment 1

[Christian Riechers]

(In reply to Thomas D. (:thomas8) from comment #0)

I keep looking for a close button in the upper right corner.

I fully agree. The current state of the customization window is awkward. Is it a window in the first place? It somehow covers the entire application window, and clicking the x button at the top right corner will close the entire application. That's very irritating.
Is there any reason why customization can't open in a new tab as Firefox does?

Comment 3

[Ikey Doherty]

Attachment: Bug 1825258: Close the customization pane upon `Escape` keypress.r=mkmelin

This is handled only when the key is released, separate from the existing
propogation code.

Comment 4

[Sören Hentzschel]

Something to consider from the duplicated bug 1832941:

It took me a while to see the 'cancel' button the first time I used it, and intuitively I tried to close it with […] the command Cmd + W (as closing a tab in the browser - as the panel uses the full window size it feels like kind of a "tab", that's why I tried this shortcut).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/df93ebd7cb1c
Close the customization pane upon Escape keypress. r=mkmelin

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9334981 [details]
Bug 1825258: Close the customization pane upon Escape keypress.r=mkmelin

[Triage Comment]
Approved for beta

Comment 7

[Wayne Mery (:wsmwk)]

verified on Daily

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 114.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/ad0bf4820cb3