1825283 - The subtitles are displayed much too high when resizing the PiP to a mini version and hovering it

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Daniel Bodea [:danibodea]]

Attachment: Screenshot from 2023-03-29 15-30-03.png

Note

• The subtitles are displayed

Found in

• Nightly v113.0a1

Affected versions

• Nightly v113.0a1

Tested platforms

• Affected platforms: Windows 10, Ubuntu 22
• Unaffected platforms:

Steps to reproduce

1. Play a video with supported subtitles (YT)
2. Launch the PiP
3. Resize PiP to the smallest version while still displaying subs.
   Just above 320:180.
4. Hover the PiP with the cursor.

Expected result

• The subtitles move upwards to avoid overlapping the lower PiP buttons, but avoiding to be in the middle of the screen as much as possible.
• I suggest moving them just above the displaying lower features (keep in mind that some features disappear while resizing it smaller).

Actual result

• The subtitles have an animation in which they move way too much upwards, even overlapping the Close and unPiP buttons.

Regression range

• First bad: Tested mozilla-central build: 2023-02-25 (verdict: b)
• Last good: Tested mozilla-central build: 2023-02-24 (verdict: g)
• Mozregression gives out a regressor that's not even in the area of PiP implementation (bug 1817248). It is most probably wrong, but the range is correct.

Additional notes

• additional_note1

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1825283 - Change how scrubber visibly is checked for ShowVideoControls. r=#pip-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f62d6b98bc05
Change how scrubber visibly is checked for ShowVideoControls. r=pip-reviewers,mhowell

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f62d6b98bc05

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Daniel Bodea [:danibodea]]

This fix has been verified in Nightly v114.0a1 on Windows 10, Ubuntu 22 and MacOS 11.