18253 - Advanced Edit dialog has mismatched tabs

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Neil Deakin]

The tabs in the advanced edit dialog are not ordered correctly.

1. Open the Advanced Edit dialog.
2. Select either of the tabs Inline Style or JavaScript Events.
3. The text on the box with the Add button will read Add a Style Attribute or
Add a JavaScript Event Handler. It doesn't match the current tab.

The tab buttons along the top aren't correct. The JavaScript one should be the
second tab.

This is a trivial fix.

By the way, I think the text should read 'Add a Style Property' should it not?

Comment 1

[rubydoo123]

assigning this to cmanske for review and setting to m14

Comment 2

[Charles Manske]

This is Ben Goodgers work.
Hey Ben -- its time to work on finishing this dialog!

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

taking this. All new advanced edit dialog bugs come to me.

Actually, I was thinking about this today, its at the top of my list of
priorities. Will have some diffs to review soon.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

checked in changes that fixes this (among other problems). Resolving fixed.

Comment 5

[sujay]

ndeakin or rgoodger, can you please verify this one and mark verified fixed?

thanks!

Comment 6

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/053d8e737d79
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18253: Remove spaces from Addons telemetry comma-separated list (https://github.com/mozilla-mobile/fenix/pull/19292)
https://hg.mozilla.org/releases/mozilla-beta/rev/5883e21a53cf
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18253: Bookmark and History open new tabs in the background (https://github.com/mozilla-mobile/fenix/pull/19275)