1825360 - Remove NS_DISPATCH_SYNC

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Nika Layzell [:nika] (ni? for response)]

This flag currently is a bit ambiguous and a potential footgun, as it spins a nested event loop until the dispatch has completed, which may be surprising to callers. In addition, many implementations of nsIEventTarget do not support the flag, either explicitly or due to the flag being ignored.

This bug is to track removing the existing flag and switching callers over to instead using a helper function which is more explicit about the behaviour.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1825360 - Remove the NS_DISPATCH_SYNC flag, r=#xpcom-reviewers

This flag is not supported by most event targets and can have unexpected
side effects (namely spinning a nested event loop). All consumers have
been replaced with a new function which is more explicit about this side
effect.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/104d913776c7
Remove the NS_DISPATCH_SYNC flag, r=necko-reviewers,geckoview-reviewers,media-playback-reviewers,karlt,jesup,m_kato,emilio

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/104d913776c7