Closed Bug 1825420 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 39276 - Fix promise_setup usage in requestStorageAccess tests

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox114 fixed)

Status:
RESOLVED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox114 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39276 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39276
Details from upstream follow.

Chris Fredrickson <cfredric@chromium.org> wrote:

Fix promise_setup usage in requestStorageAccess tests

Change-Id: I371d6cafa59ad875fa444b5e88efd613504e7949
Reviewed-on: https://chromium-review.googlesource.com/4381535
WPT-Export-Revision: 4508e41bb56e90bc145105c5c003cfe1586e63ce

PR 39276 applied with additional changes from upstream: 1c0172b4ba7082ad9acdd40441c15d924623c487, 331357d448fcfa956ca2ae36ac41802b2ba80631

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
PASS : 1
FAIL : 4

Chrome

ERROR: 1

Safari

OK : 1
PASS : 1
FAIL : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /storage-access-api/requestStorageAccess.sub.https.window.html [wpt.fyi]
    • [top-level-context] document.requestStorageAccess() should resolve in top-level frame or same-site iframe, otherwise reject with a NotAllowedError with no user gesture.: FAIL (Safari: FAIL)
    • [top-level-context] document.requestStorageAccess() should be resolved with no user gesture when a permission grant exists, and should allow cookie access: FAIL (Safari: FAIL)
    • [top-level-context] document.requestStorageAccess() should resolve without permission grant or user gesture: FAIL (Safari: FAIL)
    • [top-level-context] document.requestStorageAccess() should resolve with denied permission: FAIL (Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4f12e2b2f81 [wpt PR 39276] - Fix promise_setup usage in requestStorageAccess tests, a=testonly https://hg.mozilla.org/integration/autoland/rev/8d149934e75a [wpt PR 39276] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d4f12e2b2f81
https://hg.mozilla.org/mozilla-central/rev/8d149934e75a

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox114: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.