Closed Bug 1825603 Opened 2 years ago Closed 2 years ago

Add more logs for RemoteMediaDataDecoder

Categories

(Core :: Audio/Video, task, P1)

task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

Details

Attachments

(1 file)

The VideoDecoder interface, associated with a MediaDataDecoder, is going to be introduced in Bug 1749045, which can be run on either the main thread or the worker thread, in the content process.

While the VideoDecoder that RemoteMediaDataDecoder is associated with can run on the worker thread, the thread where RemoteMediaDataDecoder runs on, hosted by RemoteDecoderManagerChild, is created and released on the main thread only. Without extra carefulness, it's easy to have some racing issues in the code with these complex thread arrangements. It's even harder to figure out the causes of the issues without clear logs. Adding more RDD logs can be helpful to debug, especially when rr-recording couldn't capture some timing-critical intermittent racing issues.

The VideoDecoder interface, associated with a MediaDataDecoder, is
going to be introduced in Bug 1749045, which can be run on either the
main thread or the worker thread, in the content process.

While the VideoDecoder that RemoteMediaDataDecoder is associated
with can run on the worker thread, the thread where
RemoteMediaDataDecoder runs on, hosted by RemoteDecoderManagerChild,
is created and released on the main thread only. Without extra
carefulness, it's easy to have some racing issues in the code with these
complex thread arrangements. It's even harder to figure out the causes
of the issues without clear logs. Adding more RDD logs can be helpful to
debug, especially when rr-recording couldn't capture some
timing-critical intermittent racing issues.

Pushed by cchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b3c55744883f Add more logs for RemoteMediaDataDecoder r=media-playback-reviewers,alwu
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: