Closed Bug 1825635 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 39285 - Revert "Fix WPT testcases that do not properly account for counter-st…

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Product:
Core
Component:
Layout: Generated Content, Lists, and Counters
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
firefox115 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39285 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39285
Details from upstream follow.

Vitor Roriz <vitor.roriz@apple.com> wrote:

Revert "Fix WPT testcases that do not properly account for counter-st…

…yle fallback behavior of prefix/suffix descriptors."

This reverts commit 90a953f4c4f0235160e96c8dd27d4a5e7638511d.

Reverting this change since it doesn't conform to the specification: https://www.w3.org/TR/css-counter-styles-3/#counter-styles

Note: prefix and suffix don’t play a part in this algorithm. This is intentional; the prefix and suffix aren’t part of the string returned by the counter() or counters() functions. Instead, the prefix and suffix are added by the algorithm that constructs the value of the content property for the ::marker pseudo-element. This also implies that the prefix and suffix always come from the specified counter-style, even if the actual representation is constructed by a fallback style.

An issue was opened at https://github.com/w3c/csswg-drafts/issues/8619 Until we have a resolution for that I propose we revert to what spec determines. If resolution outdates this current change, then we can undo the reversion.

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5824a9a19bb0 [wpt PR 39285] - Revert "Fix WPT testcases that do not properly account for counter-st…, a=testonly https://hg.mozilla.org/integration/autoland/rev/3165edbe4643 [wpt PR 39285] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/5824a9a19bb0
https://hg.mozilla.org/mozilla-central/rev/3165edbe4643

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox115: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.