1825682 - Process IDs are truncated in sandbox file broker thread names

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

The Linux sandbox file broker runs a separate thread for each instance (each child process), which includes the child pid in the thread name in case it's useful for debugging/troubleshooting. However, the format allows only 5 characters for the pid, which was fine when the maximum pid was usually 32767 or something, and stopped being fine a while back when systemd got into the habit of setting it to 4194304 (the maximum the kernel will currently allow).

It's a one-line patch to squeeze out the spaces and get us another 2 characters, so I might as well do that.

(Long-term it would be nice to use epoll instead of separate threads — historically on Boot2Gecko we made the broker threads' effective uid/gid match their respective client processes, but that was removed in bug 1382099 — and if/when that happens this will become a non-issue.)

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1825682 - Avoid truncating the pids in Linux sandbox broker thread names.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fd16b23cbc0
Avoid truncating the pids in Linux sandbox broker thread names. r=gcp

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4fd16b23cbc0