1825745 - Make form submits do a replace load if they happen before document load has ended

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1825745 - Make form submits do a replace load if they happen before document load has ended. r?smaug!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef7d2e82eb5a
Make form submits do a replace load if they happen before document load has ended. r=smaug

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing assertion failure on nsDocShell.cpp

Backout link

Push with failures

Failure log

Comment 4

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/c5e1aa995047

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:peterv, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17472385b962
Make form submits do a replace load if they happen before document load has ended. r=smaug

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for form-submit related wpt failures.

• Backout link
• Push with failures
• Failure Log
• Failure line 1: TEST-UNEXPECTED-FAIL | /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-requestsubmit.html | Replace before load, triggered by formElement.requestSubmit() - assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement=" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&cod
• Failure line 2: TEST-UNEXPECTED-FAIL | /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html | Replace before load, triggered by submitButton.click() - assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement=" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&code

Comment 8

[Peter Van der Beken [:peterv]]

Attachment: Bug 1825745 - Fix intermittent failure of testing/web-platform/tests/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html. r?smaug!

Comment 9

[Peter Van der Beken [:peterv]]

The form submit wpt tests uncovered a different bug, where button.click() doesn't submit, because we don't yet have a prescontext. Flushing causes creation of the prescontext, but Olly is worried about the performance implications. I have attached a wip patch that tries out this approach. Olly, to be clear, this would be about the performance of a button.click() in a document where we haven't constructed the prescontext?

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Ah, true, maybe it wouldn't be too bad, it would happen only once.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ce4ceb5a39d
Make form submits do a replace load if they happen before document load has ended. r=smaug
https://hg.mozilla.org/integration/autoland/rev/eb77df0ccca6
Fix intermittent failure of testing/web-platform/tests/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html. r=smaug

Comment 12

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1825745) for causing failures in form-requestsubmit.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=eb77df0ccca6071db59faa0e8fb359e504f05e1e&searchStr=windows%2C11%2Cx86%2C22h2%2Cwebrender%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-windows11-32-2009-qr%2Fopt-web-platform-tests%2Cwpt7

Log: https://treeherder.mozilla.org/logviewer?job_id=420284207&repo=autoland&lineNumber=6105

Backout: https://hg.mozilla.org/integration/autoland/rev/d91dc862ed18d9524ee542a25a0315870da1b0e4

Comment 13

[Peter Van der Beken [:peterv]]

Attachment: Bug 1825745 - Fix intermittent failure of testing/web-platform/tests/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-requestsubmit.html. r?smaug!

Depends on D180534

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ecff353e8d46
Make form submits do a replace load if they happen before document load has ended. r=smaug
https://hg.mozilla.org/integration/autoland/rev/76d329038df4
Fix intermittent failure of testing/web-platform/tests/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html. r=smaug
https://hg.mozilla.org/integration/autoland/rev/9a98c67180c5
Fix intermittent failure of testing/web-platform/tests/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-requestsubmit.html. r=smaug

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ecff353e8d46
https://hg.mozilla.org/mozilla-central/rev/76d329038df4
https://hg.mozilla.org/mozilla-central/rev/9a98c67180c5