1825807 - Rename :open to :popover-open for popovers and remove :closed

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Joey Arhar]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36

Steps to reproduce:

In the HTML spec we are changing the :open pseudo selector for popover elements to :popover-open, and making popovers stop matching :closed.
Here is the spec PR: https://github.com/whatwg/html/pull/9077
Here are tests: https://github.com/web-platform-tests/wpt/pull/39222

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1825807: part 1) Replace popover's ':open' and ':closed' pseudo-classes with ':popover-open'. r=emilio

See https://github.com/whatwg/html/pull/9077.

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1825807: part 2) Adapt tests. r=emilio

Implements https://github.com/web-platform-tests/wpt/pull/39361 too, in
order to avoid failing CI tests.

Depends on D175223

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a82344255795
part 1) Replace popover's ':open' and ':closed' pseudo-classes with ':popover-open'. r=emilio
https://hg.mozilla.org/integration/autoland/rev/454a01f16f5b
part 2) Adapt tests. r=emilio

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39517 for changes under testing/web-platform/tests

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1825807) for causing failures in /browser_parsable_css.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=NzprsMMHQym-6fKNTtiusg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=454a01f16f5b75d0f4f77ac84e772e6b09c6ba83

Log:
TV https://treeherder.mozilla.org/logviewer?job_id=412272225&repo=autoland&lineNumber=5091
bc https://treeherder.mozilla.org/logviewer?job_id=412272215&repo=autoland&lineNumber=3521

Backout: https://hg.mozilla.org/integration/autoland/rev/dbbc912bec6e413a61a667493499444ad3e03a1e

Comment 8

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Looking into the failures.

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1825807: part 2) Update WPT metadata via script. r=emilio

Removes mostly previously expected failures from the metadata.

Generated via ./mach wpt-update wptreport.json.

Depends on D175223

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75d0306a2cae
part 1) Replace popover's ':open' and ':closed' pseudo-classes with ':popover-open'. r=emilio
https://hg.mozilla.org/integration/autoland/rev/85be01a97f0d
part 2) Update WPT metadata via script. r=emilio

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/75d0306a2cae
https://hg.mozilla.org/mozilla-central/rev/85be01a97f0d