1825884 - Fix wrong code landed as bustage fix in bug 1825809.

Status: RESOLVED FIXED

(MailNews Core :: General, defect)

Description

[MM]

+++ This bug was initially created as a clone of Bug #1825809 +++

https://hg.mozilla.org/comm-central/rev/f4a1c6f61865 appears to be wrong.

After a var.forget() the variable can't be dereferenced any more. This leads to crashes:
https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=bK_PZktlRGyl7wq1EegQsA.0
https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=cstxhfhaREWgoGK_PpLu6g.0

Assertion failure: mRawPtr != nullptr (You can't dereference a NULL RefPtr with operator->().), at /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:354)

Comment 1

[Kai Engert [:KaiE:]]

Yes, sorry, I should have reviewed more carefully.

I'll work on a fix.

Comment 2

[Kai Engert [:KaiE:]]

Attachment: Bug 1825884 - Don't use .forget() on objects that are referenced later. r=leftmostcat

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4f4463bed7ff
Don't use .forget() on objects that are referenced later. r=leftmostcat