Closed
Bug 1825970
Opened 2 years ago
Closed 2 years ago
Fix coverity issue CID 1524627: Performance inefficiencies in WebTransportParent.cpp
Categories
(Core :: DOM: Networking, defect, P2)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: smayya, Assigned: smayya)
Details
(Whiteboard: [necko-triaged])
Attachments
(2 obsolete files)
Fix the following coverity warning
CID 1524627: Performance inefficiencies (PASS_BY_VALUE)
/dom/webtransport/parent/WebTransportParent.cpp: 94 in mozilla::dom::WebTransportParent::Create(const nsTSubstring<char16_t> &, nsIPrincipal *, const mozilla::Maybe<mozilla::dom::IPCClientInfo> &, const bool &, const bool &, const unsigned int &, mozilla::ipc::Endpoint<mozilla::dom::PWebTransportParent> &&, std::function<void (std::tuple<const nsresult &, const unsigned char &>)> &&)::[lambda() (instance 1)]::operator ()() const()
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → smayya
Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged]
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D174842
|
||
Updated•2 years ago
|
Attachment #9327291 -
Attachment is obsolete: true
|
|
||
Updated•2 years ago
|
Attachment #9327292 -
Attachment description: WIP: Bug 1825970 - make ClientInfo movable in WebTransport classes → Bug 1825970 - make ClientInfo movable in WebTransport classes. r=#necko,jesup
|
|
Assignee | |
Comment 3•2 years ago
•
|
||
Randell, based on inputs from Nika here, fix for this issue is non-trivial and would need to de-virtualize PBackground.
Hence, I propose to mark this issue as WONTFIX.
Flags: needinfo?(rjesup)
|
|
Assignee | |
Updated•2 years ago
|
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
|
|
||
Updated•2 years ago
|
Attachment #9327292 -
Attachment is obsolete: true
|
||
Updated•2 years ago
|
Flags: needinfo?(rjesup)
You need to log in
before you can comment on or make changes to this bug.
Description
•