1826039 - Hang in "Waiting for browser" probably due to "JavaScript error: https://example.com/tests/SimpleTest/setup.js, line 21: ReferenceError: LogController is not defined"

Status: RESOLVED INCOMPLETE

(Testing :: Mochitest, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

[task 2023-04-03T01:09:45.383Z] 01:09:45     INFO - runtests.py | Waiting for browser...
[task 2023-04-03T01:09:45.383Z] 01:09:45     INFO - GECKO(7693) | 1680484185383	Marionette	DEBUG	Closed connection 1
[task 2023-04-03T01:09:45.620Z] 01:09:45     INFO - GECKO(7693) | JavaScript error: https://example.com/tests/SimpleTest/setup.js, line 21: ReferenceError: LogController is not defined
[task 2023-04-03T01:09:45.643Z] 01:09:45     INFO - GECKO(7693) | JavaScript error: https://example.com/tests/SimpleTest/setup.js, line 327: TypeError: can't access property "manifestFile", params is undefined
[task 2023-04-03T01:09:46.369Z] 01:09:46     INFO - GECKO(7693) | JavaScript error: resource://gre/modules/XULStore.sys.mjs, line 58: Error: Can't find profile directory.
[task 2023-04-03T01:10:06.896Z] 01:10:06     INFO - GECKO(7693) | 2023-04-03 01:10:06.894 firefox[7693:102008] Persistent UI failed to open file file:///Users/cltbld/Library/Saved%20Application%20State/org.mozilla.nightly.savedState/window_1.data: No such file or directory (2)
[task 2023-04-03T01:10:06.948Z] 01:10:06     INFO - GECKO(7693) | console.error: (new Error("Polling for changes failed: Unexpected content-type \"text/plain;charset=US-ASCII\".", "resource://services-settings/remote-settings.sys.mjs", 324))
[task 2023-04-03T01:16:16.994Z] 01:16:16     INFO - Buffered messages finished
[task 2023-04-03T01:16:16.995Z] 01:16:16    ERROR - TEST-UNEXPECTED-TIMEOUT | automation.py | application timed out after 370 seconds with no output

This fails immediately after importing the module and initializing the global variables.

Also note the params is undefined error a bit afterward. Not sure but one of both might be the cause why the test runs into a global timeout and Firefox is killed (bug 1414495).

Note that there is also bug 1058800 to get the LogController removed.

Comment 1

[Geoff Brown [:gbrown]]

Removing LogController is an interesting idea as it is fairly small and only referenced in a few places. LogController seems to provide support for optional logging levels and a logging file; although these may be optional in the default desktop environment, the file logging is always used on Android (mochitests log to a file, then the python harness retrieves and dumps the file). So any LogController removal would need at least part of the functionality added back.

But as you note, the LogController error is generally followed by "params is undefined". In that case I wonder, how can hookup() be called before params is defined at https://searchfox.org/mozilla-central/rev/98397ff4eac3d32b815fbb33bff147297fb972d7/testing/mochitest/tests/SimpleTest/setup.js#107 ? I don't understand what's happening.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Well, if LogController is not defined all the following global JS code will not be run. As such params will stay undefined. At a later time the harness just calls into hookup() and then fails. So I'm fairly sure the problem is related to the LogController and why it is not defined. Maybe due to some reason it fails to load via harness.xhml? Does the Mochitest harness log chrome related console errors?

Comment 3

[Geoff Brown [:gbrown]]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #2)

Well, if LogController is not defined all the following global JS code will not be run.
Yes, I see that now; thanks.

Maybe due to some reason it fails to load via harness.xhml? Does the Mochitest harness log chrome related console errors?
Sorry, I don't remember.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ahal, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I haven't seen this failure for quite some time when checking the waiting for browser hangs.