1826091 - Enable Pull To Refresh on all channels

Status: VERIFIED FIXED

(GeckoView :: Core, task, P1)

Description

[Joe M [:jmahon]]

After deliberation about whether Pull to Refresh is safe to release, we've agreed that it's been tested effectively and we have error mitigation strategies prepared if it results in any severe issues. Let's enable it on all channels starting in v112.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1826091 - Enable Pull to Refresh in release (#1521)

Comment 2

[BMO Github Automation]

Authored by https://github.com/onemahon
https://github.com/mozilla-mobile/firefox-android/commit/90a4940e470ce3e0711ca5246c15b82e628a2ebd
[main] Bug 1826091 - Enable Pull to Refresh in release (#1521)

Comment 3

[Jonathan Almeida [:jonalmeida]]

Comment on attachment 9326612 [details] [review]
[mozilla-mobile/firefox-android] Bug 1826091 - Enable Pull to Refresh in release (#1521)

Beta/Release Uplift Approval Request

• User impact if declined: Pull to refresh will not be enabled for users until 113.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open Settings -> Customize, and check that 'Pull to refresh' is enabled.

2. Visit popular sites and try to touch and drag down on the screen to make the pull-to-refresh throbber show up.
3. The page should refresh.
4. The throbber should disappear.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The risk is low because it's a feature flag that has baked in Nightly and Beta for many releases and we have decided to allow the feature to ride the trains.
• String changes made/needed: No.
• Is Android affected?: Yes

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1826091 - Enable Pull to Refresh in release (backport #1521) (#1525)

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9326612 [details] [review]
[mozilla-mobile/firefox-android] Bug 1826091 - Enable Pull to Refresh in release (#1521)

Approved for Mobile 112.0 rc1

Comment 6

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/df4751837e7c7a9e7323dd3b8fafb80b4d1e7be8
[releases_v112] Bug 1826091 - Enable Pull to Refresh in release (#1521) (#1525)

Comment 7

[Delia Pop]

Verified as fixed on Fenix RC 112.0 build 1 and Beta 112.0b9 with the following devices:

• Lenovo Yoga Tab 11 (Android 11)
• Sony Xperia Z5 Premium (Android 7.1.1)
• Poco M4 Pro (Android 12)
• OnePlus 5 (A5000) (Android 10)
• Samsung Galaxy S22 Ultra (Android 13)