1826114 - Incremental build fails with "No rule to make target '0'"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

> ./mach build && ./mach wpt --headless testing/web-platform/tests/service-workers/service-worker/
 0:01.13 Clobber not needed.
 0:01.59 Adding make options from C:\Users\sasch\Documents\GitHub\gecko-dev\mozconfig
    AUTOCLOBBER=1
    MOZ_OBJDIR=C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc
    OBJDIR=C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc
    FOUND_MOZCONFIG=C:/Users/sasch/Documents/GitHub/gecko-dev/mozconfig
    export FOUND_MOZCONFIG
  Parallelism determined by memory: using 64 jobs for 64 cores based on 63.9 GiB RAM and estimated job size of 1.0 GiB
 0:01.59 C:/Users/sasch/.mozbuild/mozmake/mozmake.exe -f client.mk -j64 -s
 0:05.00 Elapsed: 0.00s; From dist/public: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:05.00 Elapsed: 0.00s; From dist/private: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:05.08 Elapsed: 0.07s; From dist/xpi-stage: Kept 0 existing; Added/updated 90; Removed 0 files and 0 directories.
 0:05.83 Elapsed: 0.82s; From _tests: Kept 0 existing; Added/updated 1344; Removed 0 files and 0 directories.
 0:06.70 Elapsed: 1.69s; From dist/bin: Kept 0 existing; Added/updated 2725; Removed 0 files and 0 directories.
 0:07.87 Elapsed: 2.87s; From dist/include: Kept 0 existing; Added/updated 7020; Removed 0 files and 0 directories.
 0:08.04 ./buildid.h.stub
 0:08.06 ./source-repo.h.stub
 0:08.72 ./application.ini.stub
 0:08.73 ./IsCombiningDiacritic.h.stub
 0:09.16 ./application.ini.h.stub
 0:09.86 toolkit/library/rust/force-cargo-library-build
 0:10.16 browser/app
 0:11.42 dom/cache
 0:11.48 dom/credentialmanagement/identity
 0:11.67 dom/broadcastchannel
 0:11.88 dom/fetch
 0:11.94 dom/clients/manager
 0:12.20 docshell/base
 0:12.33 dom/events
 0:12.59 dom/media/mediacontrol
 0:12.72 dom/base
 0:12.78 dom/bindings
 0:12.96 dom/html
 0:13.20 dom/reporting
 0:13.31 dom/notification
 0:13.36 dom/messagechannel
 0:13.67 dom/serviceworkers
 0:13.67 dom/vr
 0:13.86 dom/workers/loader
 0:13.98 dom/worklet
 0:14.19 dom/workers/remoteworkers
 0:14.22 dom/workers
 0:14.86 gfx/vr
 0:15.63 js/xpconnect/src
 0:15.77 layout/build
 0:16.38 netwerk/protocol/http
 0:18.73 toolkit/mozapps/extensions
 0:19.31 toolkit/library/buildid.cpp.stub
 0:20.23 browser/app/firefox.exe
 0:20.52 toolkit/library
 0:21.28     Finished release [unoptimized] target(s) in 11.38s
 0:21.28 warning: the following packages contain code that will be rejected by a future version of Rust: cose v0.1.4, ntapi v0.3.7
 0:21.59 note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 4`
 0:31.00 mozmake[4]: *** No rule to make target '0', needed by 'C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc/x86_64-pc-windows-msvc/release/builtins_static.lib'.  Stop.
 0:31.00 mozmake[3]: *** [C:/Users/sasch/Documents/GitHub/gecko-dev/config/recurse.mk:72: security/manager/ssl/builtins/target] Error 2
 0:31.00 mozmake[3]: *** Waiting for unfinished jobs....
 0:36.66 mozmake[2]: *** [C:/Users/sasch/Documents/GitHub/gecko-dev/config/recurse.mk:34: compile] Error 2
 0:36.66 mozmake[1]: *** [C:/Users/sasch/Documents/GitHub/gecko-dev/config/rules.mk:361: default] Error 2
 0:36.66 mozmake: *** [client.mk:60: build] Error 2
 0:36.70 335 compiler warnings present.
Glean could not be found, so telemetry will not be reported. You may need to run |mach bootstrap|.

(Not sure why Glean is missing, bootstrapping doesn't help)

Comment 1

[Mike Hommey [:glandium]]

This comes from one of bug 1806618, bug 1825555 or bug 1808184.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Reverting 1808184 fixes this, and restoring it causes the issue again.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1808184

Comment 4

[[:sergesanspaille]]

Kagami, Can you share the content of C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc/x86_64-pc-windows-msvc/release/builtins_static.d ?

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Sure.

C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\x86_64-pc-windows-msvc\release\builtins_static.lib: C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\x86_64-pc-windows-msvc\release\build\builtins-static-249a962920cd1581\out\builtins.rs C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\x86_64-pc-windows-msvc\release\build\builtins-static-249a962920cd1581\out\version.rs C:\Users\sasch\Documents\GitHub\gecko-dev\security\manager\ssl\builtins../../../nss/lib/ckfw/builtins/certdata.txt C:\Users\sasch\Documents\GitHub\gecko-dev\security\manager\ssl\builtins../../../nss/lib/ckfw/builtins/nssckbi.h C:\Users\sasch\Documents\GitHub\gecko-dev\security\manager\ssl\builtins\build.rs C:\Users\sasch\Documents\GitHub\gecko-dev\security\manager\ssl\builtins\src\certdata.rs C:\Users\sasch\Documents\GitHub\gecko-dev\security\manager\ssl\builtins\src\internal.rs C:\Users\sasch\Documents\GitHub\gecko-dev\security\manager\ssl\builtins\src\lib.rs C:\Users\sasch\Documents\GitHub\gecko-dev\security\manager\ssl\builtins\src\pkcs11.rs C:\Users\sasch\Documents\GitHub\gecko-dev\security\manager\ssl\builtins\src\version.rs

Comment 6

[:Gijs (he/him)]

This was being discussed in #developers, and several of us are also seeing mozmake hanging when trying to do incremental builds (while clobbers are fine). This is obviously quite frustrating (clobbering after each change is very slow!), and looks like it matches the issue in bug 1825962 that we're seeing on automation. Also given soft freeze is the day after tomorrow... Would it be reasonable to back out 1808184 for now, and reland once this issue is fixed?

Comment 7

[:Gijs (he/him)]

Seems other folks asked this in #developers about the same time as my comment, oops.

Comment 8

[Cosmin Sabou [:CosminS]]

This should be fixed by the following backout: https://bugzilla.mozilla.org/show_bug.cgi?id=1808184#c10

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Thanks!

Comment 10

[[:sergesanspaille]]

Thanks for the backout. I've crafted an alternative patch in there https://phabricator.services.mozilla.com/D165808, if you can give it a try, that would be greatly appreciated.

Comment 11

[Kagami Rosylight [:saschanaz] (they/them)]

I guess you need to rebase that patch. I manually rebased locally and this time it fails with weird note:

 2:48.17 error: linking with `C:/Users/sasch/Documents/GitHub/gecko-dev/build/cargo-linker.bat` failed: exit code: 1
 2:48.17   |
 2:48.17   = note: "cmd" "/c" "C:/Users/sasch/Documents/GitHub/gecko-dev/build/cargo-linker.bat" "/NOLOGO" "C:\\Users\\sasch\\AppData\\Local\\Temp\\rustcdiOOmR\\symbols.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.0.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.1.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.10.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.11.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.12.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.13.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.14.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.15.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.2.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.3.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.4.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.5.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.6.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.7.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.8.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.build_script_build.58e89fa5-cgu.9.rcgu.o" "C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.11qp619fcg1x4wco.rcgu.o" "/LIBPATH:C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\deps" "/LIBPATH:C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd-9f65829977a28b3f.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libpanic_unwind-0e317596d7fb62b4.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_demangle-ab973503635148e8.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd_detect-60b7aa0a2358b614.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libhashbrown-cd6aa41f43f53ce3.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libminiz_oxide-88a4232a8779d8ac.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libadler-a9f9f52ac1a95cb8.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_alloc-29f32b95b7504de2.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libunwind-9830e462dc6b4b78.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcfg_if-44ab97457d9c0d23.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liblibc-71dfac72fe747b71.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liballoc-c459514f814b56b6.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_core-77d9806000248920.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcore-9380feaa1ae51240.rlib" "C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-a0d563049c58a24e.rlib" "kernel32.lib" "advapi32.lib" "userenv.lib" "kernel32.lib" "ws2_32.lib" "bcrypt.lib" "msvcrt.lib" "legacy_stdio_definitions.lib" "/NXCOMPAT" "/LIBPATH:C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "/OUT:C:/Users/sasch/Documents/GitHub/gecko-dev/obj-x86_64-pc-windows-msvc\\release\\build\\proc-macro2-e9d1cce8f44e26af\\build_script_build-e9d1cce8f44e26af.exe" "/OPT:REF,ICF" "/DEBUG" "/NATVIS:C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\intrinsic.natvis" "/NATVIS:C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\liballoc.natvis" "/NATVIS:C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\libcore.natvis" "/NATVIS:C:\\Users\\sasch\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\libstd.natvis"
 2:48.17   = note: 'C:\Users\sasch\AppData\Local\Temp\rustcdiOOmR\linker-arguments' is not recognized as an internal or external command,
 2:48.17
 2:48.17           operable program or batch file.
 2:48.17
 2:48.19
 2:48.21 error: could not compile `proc-macro2` due to previous error

🤔

Comment 12

[[:sergesanspaille]]

I finally found the problem in the original patch, and landed it with that problem fixed (it was a simple one: static archive don't use the .a suffix on Windows)