1826184 - Go button does not show when paste text with line break

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Alice0775 White]

Step to reproduce:

1. Copy the following text

https://bugzilla.mozilla
.org/

2. Paste to address bar

Actual results:
Go button does not show.

Expected results:
Go button should show.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=194e31587e6c4174702a223b448e8748b1b4a144&tochange=7e7982e97ed002b61e64b556f85866b5f6b9ce46

Suspect: Bug 1327589

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1327589

:daisuke, since you are the author of the regressor, bug 1327589, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Thank you very much for your report, Alice0775!
I also could reproduce this issue.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1826184: Show go-button even if pasting multiline text on urlbar

The direct reason why the go-button was hidden when pasting text is that
"usertyping" attribute will not be true.
https://searchfox.org/mozilla-central/rev/8433b62e54fd30663e82f090c4d31554531a2e66/browser/base/content/browser.css#754
When pasting data and removing white space or line break, call preventDefault().
https://searchfox.org/mozilla-central/rev/8433b62e54fd30663e82f090c4d31554531a2e66/browser/components/urlbar/UrlbarInput.sys.mjs#3504-3505
The other hand, if not removing any chars, _on_input() will be called because
don't call preventDefault(). And, the attribute is set in _on_input().
https://searchfox.org/mozilla-central/rev/8433b62e54fd30663e82f090c4d31554531a2e66/browser/components/urlbar/UrlbarInput.sys.mjs#3343

So, we set the attribute even if pasting data is changed as same as _on_input().

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ccbf0ef137f
Show go-button even if pasting multiline text on urlbar r=adw

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/4ccbf0ef137f

Comment 6

[Ardelean Oana, Desktop QA [:oardelean]]

Reproducible on a 2023-04-03 Nightly build on Windows 10.
Verified as fixed on Nightly 113.0a1(build ID: 20230409095525) on Windows 10, Ubuntu 22, macOS 12.
Go button is now visible and works properly.