1826374 - Hang when quickly switching between tabs with signed S/MIME messages

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, defect)

Description

[Kai Engert [:KaiE:]]

I have several tabs open with signed S/MIME messages.
I used the keyboard shortcut to cycle between them quickly.
While doing so, Thunderbird hung.

I saw that we had two different threads processing code from SMimeVerificationTask,
the main thread in CallCallback, and the transport thread in CalculateResult.

It were different objects, but all objects share a mutex, so it was a deadlock.

I think we can avoid that deadlock, while still sharing the global mutex.

In SMimeVerificationTask::CallCallback, we don't need to hold the lock while calling mListener->Notify. We can release the objects from the member variables while holding the locks, then release the lock, then make the call.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1826374 - Avoid a deadlock in SMimeVerificationTask. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c669d228b56a
Avoid a deadlock in SMimeVerificationTask. r=mkmelin

Comment 3

[Kai Engert [:KaiE:]]

Comment on attachment 9326921 [details]
Bug 1826374 - Avoid a deadlock in SMimeVerificationTask. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: hang
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9326921 [details]
Bug 1826374 - Avoid a deadlock in SMimeVerificationTask. r=mkmelin

[Triage Comment]
Approved via Matrix for 102 by wsmwk

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 102.10.0:
https://hg.mozilla.org/releases/comm-esr102/rev/59744711070c

Comment 6

[Kai Engert [:KaiE:]]

Attachment: Bug 1826374 - Remove unnecessary lock that was added in bug 1811298. r=mkmelin

Depends on D175894

Comment 7

[Kai Engert [:KaiE:]]

We need to backout the original patches, it introduced bug 1828558.

I've attached a better fix, a lock introduced in bug 1811298 was unnecessary.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ebef1793369d
Remove unnecessary lock that was added in bug 1811298. r=rjl

Comment 9

[Rob Lemley [:rjl]]

Comment on attachment 9329272 [details]
Bug 1826374 - Remove unnecessary lock that was added in bug 1811298. r=mkmelin

[Triage Comment]
Approved for beta by wsmwk and kaie via Matrix

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 113.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/4acc37a85047

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9329272 [details]
Bug 1826374 - Remove unnecessary lock that was added in bug 1811298. r=mkmelin

[Triage Comment]
Approved for esr102

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 102.10.1:
https://hg.mozilla.org/releases/comm-esr102/rev/33cb267b400f