1826382 - "Decode" PCM using ffmpeg

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Paul Adenot (:padenot)]

This needs to land after 1823953.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1826382 - Vendor necessary files to decode all pcm types needed using ffmpeg. r?alwu,#media-playback-reviewers

Depends on D174654

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1826382 - Tell FFmpegAudioDecoder to now decode PCM. r?alwu,#media-playback-reviewers

This needs a bit more info in GetCodecID to figure out the correct ffmpeg codec
id.

The AudioInfo is stored on the instance, it's used in a subsequent patch.

Depends on D174655

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1826382 - Fix naming to match usual style. r?alwu

Depends on D174656

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1826382 - Teach the WAV demuxer to report the channel layout of WAV files and simplify it. r?alwu

This remove the FmtParser that was doing very little, and make it so the
FmtChunk report all attribute that it contains, not a subset of them. Depending
on the format, the format chunk can be of difference size. It's frequently 40
bytes when it's a WAVEFORMATEXTENSIBLE.

Depends on D175155

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1826382 - Update README_MOZILLA to mention that it can now handle PCM. r?alwu

Depends on D175156

Comment 6

[Paul Adenot (:padenot)]

Attachment: Bug 1826382 - Fix naming to match usual style. r?alwu

Depends on D174656

Comment 7

[Paul Adenot (:padenot)]

Attachment: Bug 1826382 - Teach the WAV demuxer to report the channel layout of WAV files and simplify it. r?alwu

This remove the FmtParser that was doing very little, and make it so the
FmtChunk report all attribute that it contains, not a subset of them. Depending
on the format, the format chunk can be of difference size. It's frequently 40
bytes when it's a WAVEFORMATEXTENSIBLE.

Depends on D175158

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 10

[Paul Adenot (:padenot)]

Attachment: Bug 1826382 - Teach FFmpegAudioDecoder to handle U8 audio data in planar an interleaved format. r?alwu

Depends on D181525

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3eb5f228d9a
Vendor necessary files to decode all pcm types needed using ffmpeg. r=alwu,media-playback-reviewers DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/3fc718561ec9
Fix naming to match usual style. r=alwu DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/2811d12803cf
Teach the WAV demuxer to report the channel layout of WAV files and simplify it. r=alwu DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/8df8290b6c33
Update README_MOZILLA to mention that it can now handle PCM. r=alwu DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/3efe02ffa1c8
Teach FFmpegAudioDecoder to handle U8 audio data in planar an interleaved format. r=alwu DONTBUILD

Comment 12

[Cristian Tuns]

Backed out for causing build bustages

• Backout link
• Push with failures
• Failure Log

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7da3b38a9dcb
Vendor necessary files to decode all pcm types needed using ffmpeg. r=alwu,media-playback-reviewers
https://hg.mozilla.org/integration/autoland/rev/852d3f1bdaa5
Fix naming to match usual style. r=alwu
https://hg.mozilla.org/integration/autoland/rev/ee63d7b81520
Teach the WAV demuxer to report the channel layout of WAV files and simplify it. r=alwu
https://hg.mozilla.org/integration/autoland/rev/067c2bd9f5af
Update README_MOZILLA to mention that it can now handle PCM. r=alwu
https://hg.mozilla.org/integration/autoland/rev/0f2c69c65f67
Teach FFmpegAudioDecoder to handle U8 audio data in planar an interleaved format. r=alwu

Comment 14

[Paul Adenot (:padenot)]

Attachment: Bug 1826382 - Disable one file in test_played.html for investigation.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8e38bf42759
Disable one file in test_played.html for investigation.

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7da3b38a9dcb
https://hg.mozilla.org/mozilla-central/rev/852d3f1bdaa5
https://hg.mozilla.org/mozilla-central/rev/ee63d7b81520
https://hg.mozilla.org/mozilla-central/rev/067c2bd9f5af
https://hg.mozilla.org/mozilla-central/rev/0f2c69c65f67
https://hg.mozilla.org/mozilla-central/rev/e8e38bf42759