Closed Bug 1826399 Opened 1 year ago Closed 1 year ago

Update PDF.js to new version 184076fe7acfae9c1e5938151d5d4f95e9e94ea5 from 2023-04-04 13:10:27

Categories

(Firefox :: PDF Viewer, enhancement)

Product:
Firefox
Component:
PDF Viewer
Type:
enhancement

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1826379
Tracking Flags:
Tracking Status
firefox113 --- affected

People

(Reporter: update-bot, Assigned: calixte)

References

Details

(Whiteboard: [3pl-filed][task_id: BTPPpkb1RiSa9cDW7l_S5Q])

Attachments

(1 file)

Bug 1826399 - Update PDF.js to 184076fe7acfae9c1e5938151d5d4f95e9e94ea5
48 bytes, text/x-phabricator-request
Details | Review

This update covers 38 commits.. Here are the overall diff statistics, and then the commit information.

toolkit/components/pdfjs/content/build/pdf.js | 34 +-
toolkit/components/pdfjs/content/build/pdf.scripting.js | 14 +-
toolkit/components/pdfjs/content/build/pdf.worker.js | 144 ++-
toolkit/components/pdfjs/content/web/debugger.css | 5 +-
toolkit/components/pdfjs/content/web/viewer-geckoview.css | 28 +-
toolkit/components/pdfjs/content/web/viewer-geckoview.js | 380 ++++------
toolkit/components/pdfjs/content/web/viewer.css | 44 +-
toolkit/components/pdfjs/content/web/viewer.js | 493 +++++--------
toolkit/components/pdfjs/moz.yaml | 4 +-
9 files changed, 495 insertions(+), 651 deletions(-)

d256168b62d95d81db4bde718cbc1a28921bdb8e by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/d256168b62d95d81db4bde718cbc1a28921bdb8e
Authored: 2023-04-03 08:57:45 +0200
Committed: 2023-04-03 09:05:07 +0200

Reduce duplication when dispatching the "switchannotationeditorparams" event

Currently we repeat virtually the same code multiple times, which can be avoided by the introduction of a simple helper function.

Files Modified:

  • web/annotation_editor_params.js

484da62f50e6516c0ed7fab9ab201d435d0a7637 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/484da62f50e6516c0ed7fab9ab201d435d0a7637
Authored: 2023-03-28 21:52:07 +0200
Committed: 2023-04-02 15:23:45 +0200

Inline PDFPageView.paintOnCanvas in the draw method, now that SVG-rendering is removed

Files Modified:

  • web/pdf_page_view.js

92cf183f56388ee2bba43b8ded641c2772a6edf5 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/92cf183f56388ee2bba43b8ded641c2772a6edf5
Authored: 2023-03-31 10:02:17 +0200
Committed: 2023-04-02 15:23:45 +0200

Re-factor the showCanvas function, reducing function calls during rendering

Files Modified:

  • web/pdf_page_view.js

6858dae1c31f4326efd719d05ce80a414190c462 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/6858dae1c31f4326efd719d05ce80a414190c462
Authored: 2023-03-28 21:51:57 +0200
Committed: 2023-04-02 15:23:45 +0200

Change the finishPaintTask/finishPaintTask helpers into private methods

Files Modified:

  • web/interfaces.js
  • web/pdf_page_view.js
  • web/pdf_thumbnail_view.js

c2f1e65cc3454a9b3e18c91b460622b13e805674 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/c2f1e65cc3454a9b3e18c91b460622b13e805674
Authored: 2023-03-28 21:51:44 +0200
Committed: 2023-04-02 15:23:45 +0200

[api-minor] Remove SVG-rendering from the viewer (PR 15173 follow-up)

Files Modified:

  • web/app.js
  • web/app_options.js
  • web/pdf_page_view.js
  • web/pdf_viewer.js
  • web/ui_utils.js

4eecd9e308f20edfb686f354e0fce7066b2ddc8e by Tim van der Meij

https://github.com/mozilla/pdf.js/commit/4eecd9e308f20edfb686f354e0fce7066b2ddc8e
Authored: 2023-04-02 15:03:13 +0200
Committed: 2023-04-02 15:03:13 +0200

Bump versions in pdfjs.config

Files Modified:

  • pdfjs.config

51113c17e948c5917dbc6846024c60479ddb304f by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/51113c17e948c5917dbc6846024c60479ddb304f
Authored: 2023-04-02 12:10:15 +0200
Committed: 2023-04-02 12:10:15 +0200

Use object-spread when dispatching events in the toolbars

This format is more compact, and should be available in all browsers that we currently support; please see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax#browser_compatibility

Files Modified:

  • web/secondary_toolbar.js
  • web/toolbar.js

b35c03ac3a064d8c27f775ed6e225e40309206fb by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/b35c03ac3a064d8c27f775ed6e225e40309206fb
Authored: 2023-04-01 15:31:25 +0200
Committed: 2023-04-01 16:00:31 +0200

[api-minor] Remove the canvasFactory option from PDFPageProxy.render (PR 16100 follow-up)

Files Modified:

  • src/display/api.js

57a307d0cd92b92e7c22b911cc37a7227780bb79 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/57a307d0cd92b92e7c22b911cc37a7227780bb79
Authored: 2023-03-30 18:36:15 +0200
Committed: 2023-03-30 18:36:15 +0200

Update the Node.js compatibility-check in the worker-thread

Please note: In Node.js environments a legacy-build must be used since only those versions include any polyfills.

Previously we'd only check if ReadableStream is natively supported, however since Node.js version 18 that's now been implemented; please see https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream#browser_compatibility
Hence we'll also check for the availability of Path2D, since that's browser-specific functionality not expected to be available in Node.js environments; please see https://developer.mozilla.org/en-US/docs/Web/API/Path2D#browser_compatibility

Files Modified:

  • src/core/worker.js
  • src/shared/compatibility.js

bb5467789be61929711f9231d0e17af6ff56755b by Mark Banner

https://github.com/mozilla/pdf.js/commit/bb5467789be61929711f9231d0e17af6ff56755b
Authored: 2023-03-30 14:37:28 +0100
Committed: 2023-03-30 14:47:31 +0100

Remove now unnecessary eslint-disable statement generated for PdfJsDefaultPreferences.sys.mjs. (bug 1825522).

Files Modified:

  • gulpfile.js

5063a6f2a9281fcf832d0e87abdacae2306b55d0 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/5063a6f2a9281fcf832d0e87abdacae2306b55d0
Authored: 2023-03-30 13:36:42 +0200
Committed: 2023-03-30 14:23:38 +0200

[api-minor] Remove the disableCombineTextItems option

Please note: This parameter has never been used within the PDF.js library/viewer itself, and it was only ever added for backwards compatibility reasons.

This parameter was added in PR 7475, over six years ago, to try and optionally maintain the previous default text-extraction behaviour.
However as part of the general text-extraction improvements in PR 13257, almost two years ago, the disableCombineTextItems functionality was accidentally "broken" in various ways. Note how the only (very basic) unit-test was updated in a way that doesn't really make sense, since generally speaking you'd expect that using the option should result in more (or at least the same number of) text-items. Furthermore there's also the recent issue 16209, where the option causes almost all textContent to be concatenated together.

Hence this patch proposes that we simply remove the disableCombineTextItems option since it's essentially unused/untested functionality, as evident from the fact that it took almost two years for someone to notice that it's broken.

Files Modified:

  • src/core/annotation.js
  • src/core/document.js
  • src/core/evaluator.js
  • src/core/worker.js
  • src/display/api.js
  • test/unit/api_spec.js

40a96a2524e6c8da2ee3643d7021efeb5f731731 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/40a96a2524e6c8da2ee3643d7021efeb5f731731
Authored: 2023-03-30 11:51:25 +0200
Committed: 2023-03-30 11:51:25 +0200

[Firefox] Stop using a baseUrl in the PDFLinkService (PR 16153 follow-up)

With the changes in PR 16153 we're no longer setting a <base href> in the Firefox PDF Viewer, hence it shouldn't be necessary to keep setting a baseUrl in the PDFLinkService-class.
Given that the original document URL is now kept, the browser itself will handle relative URLs and we can thus slightly reduce the amount of string parsing required when handling various links in the viewer.

Files Modified:

  • web/app.js
  • web/pdf_link_service.js

e0e56e9e9c7822f03d0269006bffa849aedfc27c by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/e0e56e9e9c7822f03d0269006bffa849aedfc27c
Authored: 2023-03-29 14:30:54 +0200
Committed: 2023-03-29 14:33:08 +0200

[Firefox] Set the imageResourcesPath correctly (PR 16153 follow-up)

We missed updating this path in PR 16153, which breaks loading of annotation-icons in the Firefox PDF Viewer.

Files Modified:

  • web/app_options.js

7bca3c81a9440ae50d7b37d4f88630b742e8830a by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/7bca3c81a9440ae50d7b37d4f88630b742e8830a
Authored: 2023-03-29 10:31:54 +0200
Committed: 2023-03-29 10:36:48 +0200

Fix CSS-only zooming in the viewer (PR 15812 follow-up)

Currently if you e.g. enable the useOnlyCssZoom option rendering may no longer finish as intended. To reproduce:

In this case the document will never finish rendering, since the postponeDrawing-functionality will (here incorrectly) abort rendering and with CSS-only zooming rendering is only expected to happen once per page.
To fix this we'll simply ignore any drawingDelay when CSS-only zooming is used (regardless if it's triggered via the option or the zoom-level being very large).

Files Modified:

  • web/pdf_page_view.js

2c5a2d112c23667349b6b462439183fac3736bbc by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/2c5a2d112c23667349b6b462439183fac3736bbc
Authored: 2023-03-29 10:04:20 +0200
Committed: 2023-03-29 10:04:20 +0200

Fix rotation of the zoomLayer (PR 15812 follow-up)

Currently the zoomLayer isn't rotated correctly in all cases. To reproduce:

The easiest solution, as far as I can tell, is that we always set the transform just as we did (for years) prior to the changes in PR 15812.

Files Modified:

  • web/pdf_page_view.js

a96f10e55d79028588262491a5c25e6d23adef92 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/a96f10e55d79028588262491a5c25e6d23adef92
Authored: 2023-03-28 12:00:53 +0200
Committed: 2023-03-28 13:56:46 +0200

Create a new chunk when the char is too rised compared to the previouse one

Files Added:

  • test/pdfs/issue16221.pdf

Files Modified:

  • src/core/evaluator.js
  • test/pdfs/.gitignore
  • test/test_manifest.json
  • test/unit/api_spec.js

5f5256b4c4613357034b5e1d4b93bbf48ad23492 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/5f5256b4c4613357034b5e1d4b93bbf48ad23492
Authored: 2023-03-27 11:40:58 +0200
Committed: 2023-03-27 12:01:31 +0200

ESMify some modules for m-c (bug 1824610)

Files Modified:

  • gulpfile.js
  • src/pdf.sandbox.external.js

Files Changed:

  • R085 extensions/firefox/content/PdfJsDefaultPreferences.jsm

20cbb894125c5e58e0481dbdc0b1fe2e761a2cbe by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/20cbb894125c5e58e0481dbdc0b1fe2e761a2cbe
Authored: 2023-03-27 11:34:20 +0200
Committed: 2023-03-27 11:34:20 +0200

Simplify the isPDFFunction helper function

Originally we used helper functions for checking if something was a Dictionary or Stream, and then having an initial typeof check probably made sense.
However, given that we're using instanceof nowadays the additional check longer seems necessary.

Files Modified:

  • src/core/function.js

ef70988027598d591481c533100cd9613ea642af by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/ef70988027598d591481c533100cd9613ea642af
Authored: 2023-03-25 13:25:44 +0100
Committed: 2023-03-26 12:12:49 +0200

Reduce duplication in the validateCSSFont helper function

Currently we're virtually duplicating the same code, for validating quotation marks, twice in this helper function.

The size decrease is quite small (107 bytes) and this makes the code slightly harder to reader, hence I completely understand if this patch is rejected.

Files Modified:

  • src/core/core_utils.js

71fdf804de226cafb1d4b7ae7d2ecc3c02d9fe03 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/71fdf804de226cafb1d4b7ae7d2ecc3c02d9fe03
Authored: 2023-03-26 10:35:19 +0200
Committed: 2023-03-26 10:35:19 +0200

[GeckoView] Remove unused transition CSS-rules

Given that the GeckoView-viewer doesn't have a sidebar, there's no reason to have CSS-rules for it (and the variables are also undefined).

Files Modified:

  • web/viewer-geckoview.css

167b363eb3f5fe82a56976bf738300be66e18544 by nmtigor

https://github.com/mozilla/pdf.js/commit/167b363eb3f5fe82a56976bf738300be66e18544
Authored: 2023-03-25 22:00:06 +0100
Committed: 2023-03-25 22:00:06 +0100

Write some {Object} in api.js more precise

Files Modified:

  • src/display/api.js

007c367018fe9df26b6e5c61d9c057fb1d8597f1 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/007c367018fe9df26b6e5c61d9c057fb1d8597f1
Authored: 2023-03-25 20:46:02 +0100
Committed: 2023-03-25 20:46:02 +0100

Fix spelling of occurred in a couple of comments

Files Modified:

  • src/display/editor/annotation_editor_layer.js
  • web/pdf_viewer.js

035a273d3008ee234a8e5913bf38744c13bb53c3 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/035a273d3008ee234a8e5913bf38744c13bb53c3
Authored: 2023-03-25 12:31:39 +0100
Committed: 2023-03-25 12:31:39 +0100

Use replaceAll in the recoverJsURL helper function

We can just do direct replacement when building the regular expression, rather than splitting the string into an Array and then re-joining it.

Files Modified:

  • src/core/core_utils.js

a4dfa04a0b91595fb3a1c1e68b81f15122a2f451 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/a4dfa04a0b91595fb3a1c1e68b81f15122a2f451
Authored: 2023-03-25 10:04:29 +0100
Committed: 2023-03-25 10:08:27 +0100

Enable the declaration-block-no-redundant-longhand-properties Stylelint rule

Note that these changes were done automatically, using gulp lint --fix.
This rule will help avoid unnecessary repetition in the CSS; please see https://stylelint.io/user-guide/rules/declaration-block-no-redundant-longhand-properties/

Files Modified:

  • .stylelintrc
  • examples/mobile-viewer/viewer.css
  • test/resources/reftest-analyzer.css
  • web/debugger.css

a8af946bdc5e70f193be2116d921c6f17d9bb1af by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/a8af946bdc5e70f193be2116d921c6f17d9bb1af
Authored: 2023-03-25 09:46:07 +0100
Committed: 2023-03-25 09:46:07 +0100

Update l10n files

Files Modified:

  • l10n/sc/viewer.properties

ee15ec91449c758049b3ce8fd535784bffd8f26c by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/ee15ec91449c758049b3ce8fd535784bffd8f26c
Authored: 2023-03-25 09:41:15 +0100
Committed: 2023-03-25 09:41:15 +0100

Update npm packages

Files Modified:

  • package-lock.json
  • package.json

96e34fbb7d7bb556392646a7a6720182953ac275 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/96e34fbb7d7bb556392646a7a6720182953ac275
Authored: 2023-03-21 11:37:46 +0100
Committed: 2023-03-24 10:18:32 +0100

Enable the unicorn/prefer-negative-index ESLint plugin rule

Please see https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-negative-index.md

Files Modified:

  • .eslintrc
  • src/core/core_utils.js
  • src/core/type1_parser.js
  • src/core/xfa/utils.js
  • src/core/xfa/xfa_object.js

378caa72039667566cef5a0b7863c7dbfb882489 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/378caa72039667566cef5a0b7863c7dbfb882489
Authored: 2023-03-23 14:02:02 +0100
Committed: 2023-03-23 14:07:10 +0100

Slightly reduce the size of the FontInspector-integration in the API

Given that this functionality only applies in the viewer, when PDFBug is being enabled and used, it can't hurt to slightly reduce the size of this code.

Files Modified:

  • src/display/api.js
  • src/display/font_loader.js

1fc09f02355df3c9303bf9720116562b9be86063 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/1fc09f02355df3c9303bf9720116562b9be86063
Authored: 2023-03-23 12:34:08 +0100
Committed: 2023-03-23 12:57:10 +0100

Enable the unicorn/prefer-string-replace-all ESLint plugin rule

Note that the replaceAll method still requires that a global regular expression is used, however by using this method it's immediately obvious when looking at the code that all occurrences will be replaced; please see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replaceAll#parameters

Please find additional details at https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-string-replace-all.md

Files Modified:

  • .eslintrc
  • extensions/firefox/tools/l10n.js
  • external/builder/builder.js
  • external/builder/test-fixtures.js
  • external/builder/test-fixtures_esprima.js
  • external/cmapscompress/parse.js
  • external/importL10n/locales.js
  • gulpfile.js
  • src/core/core_utils.js
  • src/core/document.js
  • src/core/evaluator.js
  • src/core/fonts.js
  • src/core/fonts_utils.js
  • src/core/metadata_parser.js
  • src/core/xfa/fonts.js
  • src/core/xfa/template.js
  • src/core/xfa/xhtml.js
  • src/core/xml_parser.js
  • src/display/content_disposition.js
  • src/scripting_api/aform.js
  • src/scripting_api/util.js
  • test/unit/xml_spec.js
  • test/webserver.js
  • web/l10n_utils.js
  • web/pdf_find_controller.js
  • web/ui_utils.js

56b46996508cbfb7e3aa5cf690b809322f5b52f1 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/56b46996508cbfb7e3aa5cf690b809322f5b52f1
Authored: 2023-03-23 09:00:54 +0100
Committed: 2023-03-23 09:25:23 +0100

Reduce some duplication in the PDFViewer.{increaseScale, decreaseScale} methods

  • Reduce a little bit of duplication by enforcing the max/min scale-values once, at the end, in the increaseScale/decreaseScale methods.
  • Convert the "private" PDFViewer scale-related methods into actually private ones, now that JavaScript supports that.

Files Modified:

  • web/pdf_viewer.js

5f64621d46339b2548e10d387eeddfa3e261d064 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/5f64621d46339b2548e10d387eeddfa3e261d064
Authored: 2023-03-22 15:31:10 +0100
Committed: 2023-03-22 15:31:10 +0100

Use String.prototype.replaceAll() where appropriate

This fairly new method allows replacing multiple occurrences within a string without having to use regular expressions.

Please refer to:

Files Modified:

  • external/builder/test-fixtures.js
  • external/builder/test-fixtures_esprima.js
  • external/importL10n/locales.js
  • src/core/catalog.js
  • src/core/core_utils.js
  • src/core/file_spec.js
  • src/display/content_disposition.js
  • test/unit/ui_utils_spec.js
  • web/pdf_link_service.js
  • web/ui_utils.js

137a2d6e30f9473ca45ae4be5088fd875316ab57 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/137a2d6e30f9473ca45ae4be5088fd875316ab57
Authored: 2023-03-22 10:40:12 +0100
Committed: 2023-03-22 10:42:52 +0100

Add even more non-standard ligatures (PR 15517 follow-up)

Given that we already create multi-byte ToUnicode entries in other cases, see e.g. the getNormalizedUnicodes table, this is hopefully fine.

Files Modified:

  • src/core/evaluator.js
  • test/test_manifest.json
  • test/unit/api_spec.js

7f80052fdfa78cc65341228ccd67786fe17c5793 by Nicolas Chevobbe

https://github.com/mozilla/pdf.js/commit/7f80052fdfa78cc65341228ccd67786fe17c5793
Authored: 2023-03-22 09:49:24 +0100
Committed: 2023-03-22 09:49:43 +0100

Use cursor:move for draggable texts and drawings (Bug 1804252)

Files Modified:

  • web/annotation_editor_layer_builder.css

122d5e549a28d6b4909ca51525fc02c8260f376c by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/122d5e549a28d6b4909ca51525fc02c8260f376c
Authored: 2023-03-22 09:38:00 +0100
Committed: 2023-03-22 09:41:19 +0100

Track previous "XRefStm"s in a Set, rather than an Object

Having just reviewed a patch touching this code, I couldn't help noticing that an Object isn't really the optimal data-structure for this and nowadays we can do better by using a Set instead.

Files Modified:

  • src/core/xref.js

d4bcfe8c16aec6c9c944437e9ae91a2a2a7e7981 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/d4bcfe8c16aec6c9c944437e9ae91a2a2a7e7981
Authored: 2023-03-21 12:24:21 +0100
Committed: 2023-03-21 21:35:57 +0100

Support multi-byte ToUnicode entries, when using predefined CMaps (issue 16176)

Hopefully this makes sense, since we already "create" multi-byte ToUnicode entries in other cases (see e.g. the getNormalizedUnicodes table).

Files Added:

  • test/pdfs/issue16176.pdf

Files Modified:

  • src/core/evaluator.js
  • test/pdfs/.gitignore
  • test/unit/api_spec.js

2d0f30a67c97657194a6e9d77cb6eafbf9172183 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/2d0f30a67c97657194a6e9d77cb6eafbf9172183
Authored: 2023-03-21 18:14:43 +0100
Committed: 2023-03-21 19:27:24 +0100

Use the position of the previous xref stream if any when saving a pdf (bug 1823296)

Files Added:

Files Modified:

  • src/core/worker.js
  • src/core/xref.js
  • src/display/api.js
  • test/test_manifest.json
  • test/unit/api_spec.js

a3ab2f679077ea5a3058934c8ee5de70f1c2c685 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/a3ab2f679077ea5a3058934c8ee5de70f1c2c685
Authored: 2023-03-20 16:34:29 +0100
Committed: 2023-03-20 16:42:39 +0100

Introduce inset-block usage in the viewer CSS

Given that the viewer always set the dir-attribute, to either LTR or RTL, we should be able to use this logical CSS property to (very slightly) reduce the size of the CSS; please see https://developer.mozilla.org/en-US/docs/Web/CSS/inset-block

Files Modified:

  • web/viewer.css

553c2e05cdb039d00413e888512b1b7967e3edd4 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/553c2e05cdb039d00413e888512b1b7967e3edd4
Authored: 2023-03-19 14:30:42 +0100
Committed: 2023-03-19 14:32:37 +0100

Introduce inset usage in the CSS files

The inset property is a nice shorthand that can be used to avoid having to specify the positions individually; please see

Files Modified:

  • test/text_layer_test.css
  • web/text_layer_builder.css
  • web/viewer-geckoview.css
  • web/viewer.css
Duplicate of this bug: 1824983

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=b9c46262f52231e16e659571fe1e89a4c9c73416

The try push is done, we found jobs with unclassified failures.

Needs Investigation (From Push Health):

  • No tests were found for flavor 'plain' and the following manifest filters:
    skip_if, run_if, fail_if, subsuite(name=None), tags(['condprof']), pathprefix(['toolkit/components/pdfjs/test'])

    Make sure the test paths (if any) are spelt correctly and the corresponding
    --flavor and --subsuite are being used. See mach mochitest --help for a
    list of valid flavors.

    • 2 of 2 failed on different tasks
      - test-windows11-64-2009-qr/opt-mochitest-plain-condprof-1 (crhPfFdfQhyDDdmy74-8oA)
      - test-linux1804-64-qr/opt-mochitest-plain-condprof-1 (diFKhYhWS9alU7tAr9HOpg)

Needs Investigation (Other Failed Jobs):

  • test-macosx1015-64-qr/debug-mochitest-devtools-chrome-spi-nw-1
    • 4 of 4 failed on the same (retriggered) task (FOfZgs8xQaCvQtnNheWp3Q, Jalfd0_ESgGDeYeH-xTa3A, KDDVOuaNRg6W1l_M5zXnkg, YDdGnPNBQ_CdmfEASbPuug)
  • test-windows11-64-2009-qr/debug-mochitest-devtools-chrome-spi-nw-1
    • 4 of 4 failed on the same (retriggered) task (GojExSE4S3yWgO3PNAKqKw, QKfYX0vUQ56ducOyXqghNg, ATtMJnfDQmaT7f3k2udRxw, EcLE63yqQKOWlE40y5kZkQ)
  • test-linux1804-64-qr/debug-mochitest-devtools-chrome-spi-nw-1
    • 4 of 4 failed on the same (retriggered) task (HOS97XGmSlujpvFPpS-wxw, MwQpv_LwSVWQsB-66rTqPg, W4tSo-3ySVKAZ59ujeRYwQ, bdVd0493SM2aghKe_kvoHw)
  • test-linux1804-64-qr/debug-mochitest-devtools-chrome-swr-1
    • 4 of 4 failed on the same (retriggered) task (Lffw7DGBShyqr3SPbUEFMg, SRkpwJXsQwmCoPAcWuk32A, ZVst8CPKQIWIZ4tbd8g7Aw, Y6obtUlrQaWmc8fjcjK8YA)
  • test-linux1804-64-qr/debug-mochitest-devtools-chrome-1
    • 4 of 4 failed on the same (retriggered) task (Kba969FpTeKehOvLyJ5q2A, PVoM0D7HT16jegysb90_oQ, Xy9Kx7jhQW2c-qpKXSaUHA, ZnxlS376SZm1zpl3wbOmdQ)
  • test-windows11-64-2009-qr/debug-mochitest-devtools-chrome-1
    • 4 of 4 failed on the same (retriggered) task (M_4tqbvCTs-O0ZQ_X5JyJA, VhPO4qVyQw2R0whCoa9a7Q, N5HKVUo0Qs2_z4PPnCUdBA, f5GMaXJ8QveVjrNweKhIDQ)
  • test-macosx1015-64-qr/debug-mochitest-devtools-chrome-1
    • 4 of 4 failed on the same (retriggered) task (K5exWGwPSo-sRgJg8bzMQg, QtGk5ssYSVORioYrAOUdkw, WZ4MMijvTAmqR5riaGS7jQ, b8_Lw7a1TvSBwXok6OIAkQ)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor toolkit/components/pdfjs/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Assignee: nobody → cdenizet
Flags: needinfo?(cdenizet)
No longer blocks: pdfjs-updates, 1804252, 1823296, 1824610, 1825522
Status: NEW → RESOLVED
Closed: 1 year ago
Duplicate of bug: 1826379
Flags: needinfo?(cdenizet)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: