Closed Bug 1826549 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 39390 - Pass bitmap images as mailboxes between processes

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
firefox115 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39390 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39390
Details from upstream follow.

Ilya Nikolaevskiy <ilnik@chromium.org> wrote:

Pass bitmap images as mailboxes between processes

This CL adds mojo structs to pass the AcceleratedStaticImageBitmaps via
mailboxes instead of serializing it as array of pixels, which first requires
a GPU readback and inevitable upload to the GPU process on the receiver side.

A callback, wrapped mojo::PendingRemote, is passed along with the serialized image, so that the sending process would keep the original image alive until the transfer completes.

Small changes to the StaticBitmapImage interface and AcceleratedStaticBitmapImage class are done to expose information required for transfer. A new factory method is also added to reconstruct the image on the receive side.

Bug:1396243
Change-Id: If05918ee256d59542e6fc8125e25a94748bf47b4
Reviewed-on: https://chromium-review.googlesource.com/4281579
WPT-Export-Revision: a30723ca0c08f3b9b11456874043fa6c07103646

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Try push failed: decision task HzzZTWHmQwyiYKn6RGH_iA returned error

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

OK : 2
PASS : 4[Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] 6[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt]
TIMEOUT: 4

Chrome

OK : 2
PASS : 6

Safari

OK : 1
PASS : 3
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /webmessaging/postMessage_cross_domain_image_transfer_2d.sub.htm [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt], TIMEOUT [Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]
    • sending 2D canvas ImageBitmap to http://not-web-platform.test:8000: PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt], TIMEOUT [Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]

New Tests That Don't Pass

  • /webmessaging/postMessage_cross_domain_image_transfer_2d.sub.htm [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt], TIMEOUT [Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: OK, Safari: OK)
    • sending 2D canvas ImageBitmap to http://not-web-platform.test:8000: PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt], TIMEOUT [Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
  • /webmessaging/postMessage_cross_domain_image_transfer_webgl.sub.htm [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt], TIMEOUT [Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: OK, Safari: ERROR)
    • sending WebGL canvas ImageBitmap to http://not-web-platform.test:8000: PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt], TIMEOUT [Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3eae74cd91c3 [wpt PR 39390] - Pass bitmap images as mailboxes between processes, a=testonly https://hg.mozilla.org/integration/autoland/rev/10e670ef32e8 [wpt PR 39390] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3eae74cd91c3
https://hg.mozilla.org/mozilla-central/rev/10e670ef32e8

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox115: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.