182658 - Create nsImageImpl class; move common code from nsImage* to it

Status: RESOLVED WONTFIX

(Core Graveyard :: Image: Painting, defect, P1)

Description

[ArronM (:paper)]

This is an offshoot of Bug 753.  The difference is that gfxIImageFrame is not
being combined, and nsIImage is not becoming an IDL.  We'll leave those issues
for that bug.

This bug is for creating an nsImage class, inherited from nsIImage.  All the
nsImage* classes will inherit from nsImage.  Common code from nsImage* can be
moved to nsImage, as well as generic "non platform optimized" functionality can
be added.  Of course, nsImage* can overide functions since they are virtual.

Here's that picture again ;)

                           +----------+
                           |nsImageGTK|
                         _ +----------+
                         /|
+--------+    +-------+ /  +----------+
|nsIImage| -> |nsImage| -> |nsImageWin|
+--------+    +-------+ \  +----------+
                        _\|
                           +---------------+
                           |nsImageWhatever|
                           +---------------+

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

fwiw, I would name the class either nsImageImpl or nsImageCommon

Comment 2

[ArronM (:paper)]

yes, might as well make it consistent with
nsIRenderingContext/nsRenderingContextImpl

Comment 3

[ArronM (:paper)]

Let's see if I can make patches and get it in before 1.4a :)

Comment 4

[Joe Drew (not getting mail)]

We don't want nsIImage at all.