Closed Bug 1826643 Opened 8 months ago Closed 4 months ago

Remove `--enable-change-array-by-copy` shell flag and `javascript.options.experimental.enable_change_array_by_copy` pref

Categories

(Core :: JavaScript Engine, task, P3)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
118 Branch
Tracking Flags:
Tracking Status
firefox118 --- fixed

People

(Reporter: tjc, Assigned: mgaudet)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1826643 - Remove Change-Array-By-Copy preferences and command line switches r?bthrall
48 bytes, text/x-phabricator-request
Details | Review
Bug 1826643 - Remove unused externs from old features r?bthrall
48 bytes, text/x-phabricator-request
Details | Review

Once bug 1811057 is resolved and the change-array-by-copy feature is fully released, we should remove the shell flag and user pref that enable/disable it so that it will always be enabled.

Blocks: 1811054
Depends on: 1811057

This code to set the enableChangeArrayByCopy property in the realm configuration for tests should also be removed from TestingFunctions.cpp:

https://searchfox.org/mozilla-central/source/js/src/builtin/TestingFunctions.cpp#206

And the --enable-change-array-by-copy flag will need to be removed from any tests that have it in the header (as well as modifying the test262 updater script to not insert that flag.)

Severity: -- → N/A
Priority: -- → P3
Assignee: nobody → mgaudet
Status: NEW → ASSIGNED
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a0a401054b4
Remove Change-Array-By-Copy preferences and command line switches r=bthrall
https://hg.mozilla.org/integration/autoland/rev/fb527cd0281d
Remove unused externs from old features r=bthrall

https://hg.mozilla.org/mozilla-central/rev/3a0a401054b4
https://hg.mozilla.org/mozilla-central/rev/fb527cd0281d

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox118: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.