1826734 - Replace mozilla::Unused with (void) in DOM: File components

Status: RESOLVED FIXED

(Core :: DOM: File, task)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1826734 - Replace mozilla::Unused with (void) in dom/{file,filesystem} r=#dom-storage-reviewers

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:saschanaz, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Two weeks?! No way, time flies!

I wonder it should warn with NS_WARN_IF(FAILED()) or QM_WARNONLY_TRY instead of just fully ignore the result.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96e1951eae03
Replace mozilla::Unused with (void) in dom/{file,filesystem} r=dom-storage-reviewers,asuth

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Kagami [:saschanaz] from comment #3)

I wonder it should warn with NS_WARN_IF(FAILED()) or QM_WARNONLY_TRY instead of just fully ignore the result.

There is already an NS_WARN_IF internally in DispatchToIOThread:

if (NS_WARN_IF(NS_FAILED(rv))) {
  return rv;
}

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Ah, that's cool!

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/96e1951eae03