Closed Bug 1826743 Opened 2 years ago Closed 2 years ago

Permafailing positioned reftest failures - scrollbar related e.g. layout/reftests/position-sticky/transformed-2.html when Gecko 113 merges to Beta on 2023-04-10

Categories

(Core :: Panning and Zooming, defect)

defect

Tracking

()

VERIFIED FIXED
113 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox111 --- unaffected
firefox112 --- unaffected
firefox113 + verified

People

(Reporter: nataliaCs, Assigned: botond)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

The bug is marked as tracked for firefox113 (nightly). We have limited time to fix this, the soft freeze is today. However, the bug still isn't assigned.

:fgriffith, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Flags: needinfo?(fgriffith)
Assignee: nobody → botond
Flags: needinfo?(fgriffith)

Confirmed that this is a regression from bug 1826499. I'm continuing to investigate.

Flags: needinfo?(botond)
Keywords: regression
Regressed by: 1826499

The |translation| variable was redeclared in the branch, shadowing the
variable in the function's top-level scope, but it's the latter that
was actually used to transform the thumb.

The patch also removes a shadowing |asyncScroll| variable, though that
one was harmless.

The previous code passed |translation| to PostTranslate() directly,
now we pass it through the TranslateThumb() helper which expects
it in CSS pixels (in particular not including the device scale).

These tests have never passed on desktop with the legacy codepath.

Try push showing the affected tests passing with the patches: https://treeherder.mozilla.org/jobs?repo=try&revision=8387d1a31b6d5079905af4f06afc05f06b32245e

Component: Layout: Positioned → Panning and Zooming
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b89011e45f7f Remove shadowing variables from the apz.scrollthumb.calc=false branch. r=hiro,dlrobertson https://hg.mozilla.org/integration/autoland/rev/0c66f734f0e7 Handle the device scale correctly in the apz.scrollthumb.recalc=false codepath. r=dlrobertson https://hg.mozilla.org/integration/autoland/rev/5b660ed7a463 Run root-scrollbar-async-zoomed-{in,out} with apz.scrollthumb.recalc=true on desktop. r=dlrobertson

The patches seem to work in today's central as beta simulation.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: