Permafailing positioned reftest failures - scrollbar related e.g. layout/reftests/position-sticky/transformed-2.html when Gecko 113 merges to Beta on 2023-04-10
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox111 | --- | unaffected |
firefox112 | --- | unaffected |
firefox113 | + | verified |
People
(Reporter: nataliaCs, Assigned: botond)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files)
- Central-as-beta-simulation
- How to run these simulations
- [Failure log]
- REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/position-sticky/transformed-2.html == layout/reftests/position-sticky/transformed-2-ref.html | image comparison, max difference: 75, number of differing pixels: 308
- REFTEST TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/reftest/async-scrollbar-1-v.html == gfx/layers/apz/test/reftest/async-scrollbar-1-v-ref.html | image comparison, max difference: 75, number of differing pixels: 492
- REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/async-scrolling/position-fixed-transformed-1.html == layout/reftests/async-scrolling/position-fixed-transformed-1-ref.html | image comparison, max difference: 75, number of differing pixels: 632
Botond, can you please check if these were caused by Bug 1826499?
Thank you.
![]() |
||
Updated•2 years ago
|
Comment 2•2 years ago
|
||
The bug is marked as tracked for firefox113 (nightly). We have limited time to fix this, the soft freeze is today. However, the bug still isn't assigned.
:fgriffith, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Confirmed that this is a regression from bug 1826499. I'm continuing to investigate.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
The |translation| variable was redeclared in the branch, shadowing the
variable in the function's top-level scope, but it's the latter that
was actually used to transform the thumb.
The patch also removes a shadowing |asyncScroll| variable, though that
one was harmless.
Assignee | ||
Comment 5•2 years ago
|
||
The previous code passed |translation| to PostTranslate() directly,
now we pass it through the TranslateThumb() helper which expects
it in CSS pixels (in particular not including the device scale).
Assignee | ||
Comment 6•2 years ago
|
||
These tests have never passed on desktop with the legacy codepath.
Assignee | ||
Comment 7•2 years ago
|
||
Try push showing the affected tests passing with the patches: https://treeherder.mozilla.org/jobs?repo=try&revision=8387d1a31b6d5079905af4f06afc05f06b32245e
Assignee | ||
Updated•2 years ago
|
Comment 9•2 years ago
|
||
The patches seem to work in today's central as beta simulation.
Comment 10•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b89011e45f7f
https://hg.mozilla.org/mozilla-central/rev/0c66f734f0e7
https://hg.mozilla.org/mozilla-central/rev/5b660ed7a463
Comment 11•2 years ago
|
||
Working in today's beta-simulation: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=1ea0fe8c3684cff7fe0a88832e8aea8631206a60&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Creftests%2Ctest-linux1804-64-qr%2Fdebug-reftest%2Cr&selectedTaskRun=fuNEzLkGSNe1N1LUkcZnTg.0
Comment hidden (Intermittent Failures Robot) |
Description
•