1826751 - Remove login popup has its buttons shifted to the right

Status: NEW

(Firefox :: about:logins, defect, P3)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: remove login popup.png

Found in

• Firefox 112.0

Affected versions

• Firefox 112.0
• Firefox 113.0a1

Tested platforms

• Affected platforms: macOS 11.7.5, Ubuntu 22.04
• Unaffected platforms: Windows 11

Preconditions

• Have a saved password in about:logins

Steps to reproduce

1. Launch Firefox
2. Access about:logins
3. Select Remove on any entry in the list

Expected result

• The "Cancel and Remove" buttons are centered in the popup

Actual result

• The "Cancel and Remove" buttons are shifted to the right part of the popup

Regression range

• This has been introduced in 109.0a1 (in 2022-12-07/08)
  Pushlog - Bug 1802377 - Use moz-button-group in export logins dialog

Additional notes

• The issue can be seen in the attachment

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:mstriemer, since you are the author of the regressor, bug 1802377, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: image.png

I reached out to Jules from the Design Systems team and they suggested that the dialog should ideally look like this.

I don't think it needs to be exactly like that (although that would be nice!), but the issue with this dialog is more that it is centre aligned and narrow than the buttons being right aligned.

Jules also mentioned that the "Remove" button should actually be labelled "Remove login", similar to how Quit confirmation dialog which says "Quit Firefox"

Comment 3

[Sergey Galich [:serg]]

I think it's enough to just set min-width=? to this dialog, but ...lets not do much here yet. I'd rather have it as a tab modal instead of in-page dialog, because there are other places user can "remove login" and we don't ask for confirmation there :(