1826774 - Look up missing ordering property by looking up other cards via the card type

Status: RESOLVED INVALID

(Firefox for Android :: Onboarding, task)

Description

[James Hugman [:jhugman] [@jhugman]]

This is to ensure that cards that don't include an ordering property use their type to lookup one that does, so we can run experiments on conditional cards at the same time as rollouts that play with the ordering.

"cards": {
   "set-to-default-en": {
      "type": "set-to-default",
      "text": "Make it permanent!"
   }
}

and

"cards": {
   "set-to-default": {
       "ordering": 10
   }
}

Make the ordering optional in the FML
When unpacking/sorting, look up the ordering (when not set) from card looked up by the type, for example:

val rawCards = feature.cards
val cards = rawCards.map { (key, value) -> 
    val type = value.type ?: reportMalformed(key)
    val ordering = value.ordering ?: rawCards[type.toString()]?.ordering ?: reportMalformed(key)
    …
}

Comment 1

[twhite]

Not required for current requirements.