182681 - [FIX]<select size="0"> draws an inappropriate control

Status: RESOLVED FIXED

(Camino Graveyard :: HTML Form Controls, defect, P3)

Description

[Mark Mentovai]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021104 Chimera/0.6
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021128 Chimera/0.6+

With ambiguous but valid HTML <select size="0">, Chimera will draw what appears
to be an <input type="text">.  It functions as a drop-down menu of the type
created with <select size="1">, but no visual cues are present to inform the
user that it will function this way.  This can be viewed at
http://www.mentovai.com/tmp/chimera-bug-200211291315.html.  It was found in the
wild at http://www.nyc.gov/html/tlc/, under "TLC Rules."

This occurs with other improper values for the size parameter.

Reproducible: Always

Steps to Reproduce:
Use <select size="0">
Actual Results:  
Control that resembles <input type="text"> is displayed but it functions as a
<select size="1">

Expected Results:  
Chimera should have drawn the control as a <select size="1">

0.6+-2002112805/10.2.2
0.6-2002110415/10.2.2

Comment 1

[Greg K.]

Confirmed using Chimera/2002112604. See also bug 182476.

Comment 2

[Simon Fraser [no longer active]]

Attachment: Testcase

Comment 3

[Simon Fraser [no longer active]]

Test url is dead. Attached testcase.

Comment 4

[Ari]

Attachment: patch

Here are the <select> changes that were in my patch for bug 197094 that fix
this bug.

Comment 5

[Brian Ryner (not reading)]

It seems like the select[multiple] portion of this should be in forms.css since
that bug would affect all platforms.  Also, the fix for size=0 should be
mirrored in forms.css.  (this is what we want to do, right jkeiser/bz ?)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Yeah, we should probably mirror this in forms.css.... (Assuming that it doesn't
crash and burn on Windows, of course, which I can't test.  And -moz-appearance
does not seem to do anything for Linux form controls, yet.)

Comment 7

[Brian Ryner (not reading)]

Comment on attachment 120030 [details] [diff] [review]
patch

minusing to get this out of my review queue, since we decided part of this
should be in forms.css.

Comment 8

[John Keiser (jkeiser)]

Agreed, size="0" part of the fix should be in layout/html/document/src/forms.css.

Comment 9

[Ludovic Hirlimann [:Usul]]

still present in 2003082402.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: patch taking comments into account

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 132121 [details] [diff] [review]
patch taking comments into account

Reviews?  I optimized for maintainability, but we could move a copy of the
"size" rule with "multiple" after the 'size=1' rule...

Comment 12

[Boris Zbarsky [:bzbarsky]]

Taking.

Comment 13

[Brian Ryner (not reading)]

Comment on attachment 132121 [details] [diff] [review]
patch taking comments into account

Looks ok to me.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 132121 [details] [diff] [review]
patch taking comments into account

Do I want to know why this is copied into a mac-specific file?

Comment 15

[Boris Zbarsky [:bzbarsky]]

It's copied because said file includes some mac-specific rules (eg setting the
transparent background....)

Patch checked in.