1826821 - [wpt-sync] Sync PR 39412 - Fix crash when determining the static-position.

Status: RESOLVED FIXED

(Core :: Layout: Positioned, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39412 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39412
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

Fix crash when determining the static-position.

Patch: https://chromium-review.googlesource.com/c/chromium/src/+/4394857

...introduced a NOTREACHED_NORETURN() to
ContainingBlockLogicalWidthForPositioned. Turns out this was reachable!

When we compute the static-position from "legacy" within:
LayoutNGMixin\<Base>::UpdateOutOfFlowBlockLayout

However the result of this static-position call shouldn't be needed as
this codepath should always require at least one inset set in both axes.

Bug: 1431205
Change-Id: I81a463bf9fab8fb2958065bb3e7a51dfea3e82ef
Reviewed-on: https://chromium-review.googlesource.com/4406493
WPT-Export-Revision: d92a87e345f760a0d6b8a3d5961abf3601bb64d6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1305dd0e7e170e4294890661b51a2ad250bb211f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79f1a201a843
[wpt PR 39412] - Fix crash when determining the static-position., a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/79f1a201a843