1826826 - [wpt-sync] Sync PR 39414 - Dispatch page visibility change async when script execution is possible

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39414 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39414
Details from upstream follow.

Andrey Kosyakov <[e-mail]> wrote:

Dispatch page visibility change async when script execution is possible

• disable scripts when dispatching PageVisibilityChanged, as a script
  may cause a mutation of the observer set being iterated;
• defer wake lock release upon page becoming hidden;
• defer gamepad events dispatch upon page becoming visible.

Bug: 1348019
Change-Id: I031a2465431e440f8521a4b5a6d706fa71623938
Reviewed-on: https://chromium-review.googlesource.com/4403615
WPT-Export-Revision: f37f4a68e7f547a7e58d89383d8de97b4dac5dc3

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=667c479715656d57cd9fb879818c1f3c868eb73c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1

Chrome

CRASH: 1

Safari

OK : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /screen-wake-lock/chrome-bug-1348019.https.html [wpt.fyi]
  • Appending iframe in release event listener does not cause a crash when page visibility changes: FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74b0fb5cac4d
[wpt PR 39414] - Use HeapLinkedHashSet to maintain page visibility observers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/acde6272be88
[wpt PR 39414] - Update wpt metadata, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/74b0fb5cac4d
https://hg.mozilla.org/mozilla-central/rev/acde6272be88