1826840 - [meta] Optimize scripted proxies in CacheIR

Status: NEW

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Iain Ireland [:iain]]

Proxies are seeing increasing usage in performance-sensitive code. The Vue test in Speedometer 3 is the most important, but there are other frameworks like MobX that are starting to make heavier use of proxies. V8 does better than we do in some cases. In bug 1824051, Jeff observed that if we could match V8’s performance on proxies, we would improve on the test by 8.5%.

One option is to generate ICs specialized to a particular proxy handler object. Consider the following hypothetical GetProp CacheIR (including some ops that don’t exist yet):

  GuardToObject        	 
  GuardIsScriptedProxy 	   // Check that this is a proxy
  LoadScriptedProxyHandler // Load the handler object
  GuardShape           	   // Guard the shape of the handler
  LoadFixedSlot        	   // Load the 'get' hook
  GuardSpecificFunction	   // Guard that it's a particular function
  CallScriptedProxyGet 	   // Call and validate result
  ReturnFromIC

The same sequence could be used for GetElem. Similar sequences could be used for SetProp/SetElem/HasProp.

We have to do some validation of the return values after calling. One alternative is to generate a call to a self-hosted function instead of adding CallScriptedProxyGet.

More details in this document.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:willyelm, maybe it's time to close this bug?

Comment 2

[Iain Ireland [:iain]]

The work to support GetProp/GetElem was done in bug 1824051.

We could consider extending that approach to handle other proxy traps, like set and has.