Closed Bug 1826843 Opened 2 years ago Closed 2 years ago

Define --in-content-button- variables based on design tokens

Categories

(Toolkit :: Themes, task)

Product:
Toolkit
Component:
Themes
Type:
task

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1835869

People

(Reporter: mstriemer, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Bug 1798404 introduces some design tokens for moz-toggle, this should also provide most of the tokens we need for buttons. We'll likely need to add text color and potentially some spacing tokens to fully update the button rules to be based on design tokens.

Since the --in-content-button-* variables are used in so many places it would make sense to leave those rules in common-shared.css for now and have them be defined by the design tokens like --in-content-button-background: var(--button-background-color). It would be nice if the button styles used the design tokens, but the old variables are left to support existing uses.

Removing the --in-content-button-* variables and updating existing uses can happen in one or more follow up tickets.

See Also: → 1839648

Work is happening in bug 1835869

Status: NEW → RESOLVED
Closed: 2 years ago
Duplicate of bug: 1835869
Resolution: --- → DUPLICATE
Whiteboard: [fidefe-reusable-components] → [recomp]
You need to log in before you can comment on or make changes to this bug.