1826883 - Rename Juno onboarding references to represent new user onboarding

Status: RESOLVED FIXED

(Fenix :: Onboarding, task, P3)

Description

[Jonathan Almeida [:jonalmeida]]

Based on an offline conversation with :jmahon, the new onboarding flow will be retained within our codebase after the Juno release, so we should avoid using that naming convention as there will be no long term reference to what "Juno" means after this release.

For a few examples, consider renaming:

• isJunoOnboardingShown -> isNewUserOnboardingShown
• JunoOnboardingFragment -> NewUserOnboardingFragment
• JunoOnboardingMapper.kt -> NewUserOnboardingMapper.kt

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

We have discussed this in https://github.com/mozilla-mobile/firefox-android/pull/1442#discussion_r1150978629. We could certainly use this bug to track this work.

Comment 2

[Joe M [:jmahon]]

Copying my comment from Bug 1826967 to close that as a duplicate:

(I hadn't seen this ticket prior to writing this comment, sorry!)

I'm worried about the conceptual debt involved in encoding the term "Juno" into the codebase. After the Juno marketing moment passes in June 2023, the term "Juno" will be somewhat confusing to see still floating around. E.g., we shouldn't refer to the new card-based onboarding flow as "Juno Onboarding", since that might imply it's only part of the Juno release (v114), whereas this new onboarding redesign will be used in perpetuity after Juno.

I think it'd be helpful to remove references to Juno - at least in places where it's easy to do so - to prevent this confusion. If simply calling it "onboarding" isn't specific enough, perhaps a descriptive name would work better, e.g. "cardBasedOnboarding" or "onboardingV2" to distinguish it from the previous flow.

Comment 4

[Rahul Sainani [:rsainani]]

Now that the older scrolling onboarding has been removed, we can simply remove the Juno prefix and not add a New prefix as that'll be incorrect after a while too.

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1826883 - Remove juno prefix from onboarding (#4625)

Comment 6

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/e877e29ae9ee17e3dc4c64400f00f1661b0b81dc
[main] Bug 1826883 - Remove juno prefix from onboarding