1826884 - Don't show Top Picks while search terms persist in the Urlbar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[James Teow [:jteow]]

From :adw (I was also able to reproduce):

1. Open a new tab (not sure if this is necessary)
2. Click in the urlbar to show the top sites.
3. Do a search and verify search terms are persisted.
4. Click in the urlbar again.

Expected Result:

• The urlbar should show suggestions pertaining to the persisted search term.

Actual Result:

• The top sites show again.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1826884 - Don't show cached Top Picks if persisted search terms are present - r?adw

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1818848

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82c1ab62fcab
Don't show cached Top Picks if persisted search terms are present - r=adw

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1818848

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/82c1ab62fcab

Comment 6

[James Teow [:jteow]]

Comment on attachment 9327454 [details]
Bug 1826884 - Don't show cached Top Picks if persisted search terms are present - r?adw

Beta/Release Uplift Approval Request

• User impact if declined: Users enrolled in the persisted search terms experiment in Fx 113 may be unable to see suggestions related to the persisted search term when focusing the urlbar from the context of a search engine results page.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see comment 1 in the thread.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The list of Top Sites are cached and retrieved in the Urlbar results.

The condition I added ensures we don't show cached Top Sites results if this.window.gBrowser.selectedBrowser.searchTerms has an actual value.

For users not enrolled in the experiment and/or who don't have the persisted search terms feature enabled, this.window.gBrowser.selectedBrowser.searchTerms will always be blank. Thus, this change shouldn't affect the vast majority of users.

• String changes made/needed:
• Is Android affected?: No

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9327454 [details]
Bug 1826884 - Don't show cached Top Picks if persisted search terms are present - r?adw

Approved for 113 beta 3, thanks.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/1e5c0a364fdf

Comment 9

[Ardelean Oana, Desktop QA [:oardelean]]

Reproducible on a 2023-04-09 Nightly build on macOS 12.
Verified as fixed on Firefox 113.0b3(build ID: 20230412155147) and Nightly 114.0a1(build ID: 20230412092401) on macOS 12, Windows 10, Ubuntu 22.
The urlbar now shows suggestions pertaining to the persisted search term.

Comment 10

[Dianna Smith [:diannaS]]

setting 112 as wontfix since 'Persist Search Term' is expected to ride the 113 trains.
If anything changes in regards to 112, please let me know.