1826935 - `Reversed` does not work with a temporary object

Status: NEW

(Core :: MFBT, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

AutoTArray<RefPtr<Element>, 10> elements;
for (const auto& e : Reversed(elements.Clone())) {
  e->foo();
}

In this case, the result of Clone() creates a temporary object which is not available from the range-based for loop.

I think that there should be a class of reversing the range with moving and storing the temporary object. Then, such for loop does not need to create an array outside the for.

If this is not reasonable, I think that this should cause an error of clang-plugin if Reversed is called with a temporary object.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them) (OOO until Dec 11)]

If this is not reasonable, I think that this should cause an error of clang-plugin if Reversed is called with a temporary object.

I wonder it can define an rvalue overload and add static_assert.