1826944 - Juno onboarding doesn't turn to landscape mode on tablets

Status: VERIFIED FIXED

(Firefox for Android :: Onboarding, defect)

Description

[Mira Lobontiu (Android QA)]

Attachment: lanscape.mp4

Prerequisites

Make sure the device has the "Auto-rotate" option enabled.

Steps to reproduce

1. Install the latest Fenix Nightly 113.0a1 from 4/7.
2. Hold the device in landscape mode.
3. Open Fenix Nightly and observe the new onboarding.

Expected behavior

The new onboarding is displayed in landscape mode.

Actual behavior

The new onboarding is displayed in portrait mode, even if the devices is held in landscape mode.

Device information

• Firefox version: Nightly 113.0a1 from 4/7
• Android devices: Lenovo tablet M10 (Android 10), Samsung Galaxy Note 8 (Android 9), Google Pixel 6 (Android 13)

Any additional information?

• The options from the new onboarding are working without issues.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:rsainani, since you are the author of the regressor, bug 1826387, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

From @aarjav in https://mozilla.slack.com/archives/C016PEDKY90/p1681140975788439?thread_ts=1681110003.382639&cid=C016PEDKY90, we want to update it to switch to landscape mode only for tablets.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1826944 - Onboarding now follows device orientation for tablets (#1613)

Comment 4

[Mira Lobontiu (Android QA)]

I've updated the title of the bug, because the expected behavior is that the new onboarding should turn into landscape mode only on tablets, not on phones.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1826387

Comment 6

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/4b46df8596a77f2775e4045f2a3edd2dd1f432ec
[main] Bug 1826944 - Onboarding now follows device orientation for tablets

Comment 7

[Chris Peterson [:cpeterson]]

Rahul says Juno onboarding is disabled in 113, so there's no need to uplift this fix to Beta 113.

Comment 8

[Rahul Sainani [:rsainani]]

Sorry Chris, let me rephrase, what I meant was it's only disabled in nightly 113, we do plan to run experiments on 113 beta and release. And now we've enabled it with Bug 1827030 for nightly as well. Both of these can be uplifted to beta once they are qe verified.

Comment 9

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Fenix Nightly 114.0a1 from 4/19 with the Lenovo tablet M10 (Android 10).

Comment 10

[Chris Peterson [:cpeterson]]

Setting status-firefox113=affected because Rahul says we plan to run some Juno onboarding experiments in 113 and he recommends we uplift this fix to 113.

Comment 11

[Rahul Sainani [:rsainani]]

Joe, I'd like to request uplift to 113 beta for this. Does it look good to you?

Comment 12

[Joe M [:jmahon]]

Yes, thank you!

Comment 13

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1826944 - Onboarding now follows device orientation for tablets (backport #1613) (#1722)

Comment 14

[Rahul Sainani [:rsainani]]

Comment on attachment 9329640 [details] [review]
[mozilla-mobile/firefox-android] Bug 1826944 - Onboarding now follows device orientation for tablets (backport #1613) (#1722)

Beta/Release Uplift Approval Request

• User impact if declined: Tablets would be locked to portrait on juno onboarding.
  This patch allows juno onboarding to be viewed in portrait or landscape on tablets.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open the app as a new user (clearing any previous app data if necessary) on a tablet.

2. Juno onboarding should show up if the experiment is selected. If not, go into the secret settings and select treatment-a for redesigned onboarding experiment.
3. Rotate the tablet to landscape and portrait - the juno onboarding should follow the device orientation and should not be locked in portrait.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's not risky as it's a small code change that results in a good user experience for tablet users. It only impacts new tablet users.
• String changes made/needed: no
• Is Android affected?: Yes

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9329640 [details] [review]
[mozilla-mobile/firefox-android] Bug 1826944 - Onboarding now follows device orientation for tablets (backport #1613) (#1722)

Approved for 113.0b7.

Comment 16

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/1bfebb94377b670e4a88504f99b581eaf2673c51
[releases_v113] Bug 1826944 - Onboarding now follows device orientation for tablets

Comment 17

[Delia Pop (Android QA)]

Verified as fixed on Beta 113.0b7.
Devices used:

• Lenovo Yoga Tab 11 (Android 11)
• Lenovo Tab M10 (Android 10)
• Huawei MediaPad T5 (Android 8)
• Huawei MediaPad M2 (Android 5.1.1)