1827001 - [wpt-sync] Sync PR 39433 - Add checks before deserializing an object in AudioWorkletProcessor

Status: RESOLVED FIXED

(Core :: Web Audio, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39433 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39433
Details from upstream follow.

Hongchan Choi <[e-mail]> wrote:

Add checks before deserializing an object in AudioWorkletProcessor

This CL adds two more steps before deserializing a transferred object
from AudioWorkletNode to AudioWorkletProcessor:

1. Use SerializedScriptValue->CanSerializeIn() check to before
   unpacking.
2. Then use UnpackedSerializedScriptValue() to unpack.
3. Rewrite the related WPT to simplify and remove redundant dependency.

Bug: 1429681
Change-Id: I0f24b7e92c23e2abc8402248aa5e410eb4da3786

Reviewed-on: https://chromium-review.googlesource.com/4406357
WPT-Export-Revision: c315bd405dd05377bee3c147e0c354e021cdbb14

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

PASS : 1
TIMEOUT: 2
NOTRUN : 1

Chrome

PASS : 1
TIMEOUT: 2
NOTRUN : 1

Safari

OK : 1
PASS : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-onerror.https.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: OK)
  • Test if |onprocessorerror| is called for a transfered object that cannot be deserialized on the AudioWorkletGlobalScope.: TIMEOUT (Chrome: TIMEOUT, Safari: PASS)
  • Test if |onprocessorerror| is called upon failure of process() method.: NOTRUN (Chrome: NOTRUN, Safari: PASS)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bc5f899e69d
[wpt PR 39433] - Add checks before deserializing an object in AudioWorkletProcessor, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4c1ef87a693c
[wpt PR 39433] - Update wpt metadata, a=testonly

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5bc5f899e69d
https://hg.mozilla.org/mozilla-central/rev/4c1ef87a693c