Closed Bug 1827334 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 39466 - Set Opus Signal for DTX

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox114 fixed)

Status:
RESOLVED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox114 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39466 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39466
Details from upstream follow.

Thomas Guilbert <tguilbert@chromium.org> wrote:

Set Opus Signal for DTX

Setting DTX for OPUS does not work, unless we explicitly set the signal
hint to OPUS_SIGNAL_VOICE. This workaround is already present in
WebRTC code 1, and it's unlikely that one would use DTX for music
content anyways.

This CL sets or unsets the signal hint appropriately for use with the
DTX flag.

Bug: 1415321
Change-Id: I08ce6f392314d87fd6f7f74358fa9eb89ae75e99
Reviewed-on: https://chromium-review.googlesource.com/4412024
WPT-Export-Revision: 0733ecad978a54ed69792c18adcf7620ff89b788

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d645fd2b292 [wpt PR 39466] - Set Opus Signal for DTX, a=testonly https://hg.mozilla.org/integration/autoland/rev/eb3a3262b74d [wpt PR 39466] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/3d645fd2b292
https://hg.mozilla.org/mozilla-central/rev/eb3a3262b74d

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox114: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.